Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markAsRead = false changes all messages to unread #6

Open
jakubdal opened this issue May 10, 2017 · 1 comment
Open

markAsRead = false changes all messages to unread #6

jakubdal opened this issue May 10, 2017 · 1 comment

Comments

@jakubdal
Copy link

First of all I wanted to say that I really love this repository :)

I find it odd that setting markAsRead to false marks messages as unread, even if they were previously mark as read.

Not sure if it's a bug or a feature. Just an odd behaviour for me.
@jprobinson
Copy link
Owner

Oh my! Yes, this is definitely a bug. Thanks for pointing it out! I guess I've missed this as I generally pull unread messages, not read ones.

We should probably check if a message has the 'SEEN' flag before removing it in some cases. I'll see if I can find some time to work up a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jprobinson @jakubdal