You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently axios is bundled inside dist/*.js. Probably that's why listed only as a dev dependency.
IMHO axios should be peerDependency and not bundled into dist.
If you use js-data-http, then axios is bundled into dist/js-data-http.js. If you use js-data-fetch, axios is not bundled, and you need to provide an agent, such as superagent. If you use js-data-http-node, then axios is a prod dependency and will be installed and loaded by your app. I will add axios as a prod dependency of js-data-http.
I agree with @Hagith and think axios should be a peerDependency. If you're using js-data-http but are using axios in your app for other requests, would it then not end up being bundled twice?
I noticed axios belongs here to devDependencies but IMO it's a prod dependency.
The text was updated successfully, but these errors were encountered: