-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure storage logs should have a useful correlationId #1179
Comments
I've submitted #1178 to address this. |
This PR changes no behavior except to provide a settings "hook" that you can use to pass-through azure cli request options. There was already one such option being passed through, `timeout`, so I've refactored things slighly to avoid duplication.
This PR adds a settings "hook" that you can use to pass-through azure cli request options, and uses it to set the "client_request_id" by default if django-guid is installed. There was already one such option being passed through, `timeout`, so I've refactored things slighly to avoid duplication.
@jschneier In the interest of helping this Issue along I have created a couple of other pull requests, either of which would close this issue. You said here that your issues with the original PR were:
In the first option, #1467, I provide a completely generic The second option, #1468, is identical except it by default sets I think that "use django-guid by default if installed" is the best level of dependency here to do the "right thing" from a user perspective, even if they don't know it. But if you disagree then hopefully the first option is acceptable; it allows users to set available Azure Storage options and would allow us to get back onto a standard version of django-storages (when merged / released). I'll also point out that Microsoft provides free Azure credits for open-source developers to aid with your testing / developing, which you may want to look into regardless of these PRs. Please let me know if there are any changes you need in order to make this mergable. |
This PR adds a settings "hook" that you can use to pass-through azure cli request options, and uses it to set the "client_request_id" by default if django-guid is installed. There was already one such option being passed through, `timeout`, so I've refactored things slighly to avoid duplication.
This PR changes no behavior except to provide a settings "hook" that you can use to pass-through azure cli request options. There was already one such option being passed through, `timeout`, so I've refactored things slighly to avoid duplication.
This PR changes no behavior except to provide a settings "hook" that you can use to pass-through azure cli request options. There was already one such option being passed through, `timeout`, so I've refactored things slighly to avoid duplication.
Common practice is to create a correlationId for any user-facing service request and apply that single correlationId to all services invoked while handling that request. The django-guid plug-in is the standard mechanism for setting such a guid, and logs emitted by django itself include that id.
Azure storage API calls can optionally pass a correlationId which is attached to log entries created by Azure while handling the request. The guid passed into django-guid should be plumbed through to any calls to Azure storage APIs to enable log correlation across all services when investigating problems.
The text was updated successfully, but these errors were encountered: