Refactor tests into modules #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we don't compile the tests into the resulting library, this commit wraps all the xdr_nom tests into modules. It also spreads out some of the tests into multiple to give finer tuned identification of each.
nbsdx
pushed a commit
to nbsdx/rust-xdr
that referenced
this pull request
Mar 14, 2020
Includes a fix in `xdrgen/sr/spec/xdr_nom.rs` on line 364 - it was incorrectly `#[cfg(mod)]` when it should have been `#[cfg(test)]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we don't compile the tests into the resulting library, this
commit wraps all the xdr_nom tests into modules. It also spreads out
some of the tests into multiple to give finer tuned identification of
each.
fixes #32