Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error message for export command #5

Open
jskimdev opened this issue Apr 19, 2024 · 1 comment
Open

Incorrect error message for export command #5

jskimdev opened this issue Apr 19, 2024 · 1 comment

Comments

@jskimdev
Copy link
Owner

jskimdev commented Apr 19, 2024

스크린샷 2024-04-19 164354.png

When a wrong flag given as shown in the image, the application gives a wrong error message saying

At least 1 flag should be provided!

It would be good to give an error message that indicates that the flag/field is invalid.

@nus-se-bot
Copy link

nus-se-bot commented Apr 22, 2024

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error Message Shown Does Not Match Error

Description

When there is an invalid flag input when trying to export the chosen details of the filtered persons, the error message shown is not suitable for the error. The error message shown is 'At least 1 flag should be provided!'. The input format is correct, but the flag is invalid. A more suitable error message could have been shown instead.

Steps to Reproduce

export o/

Expected

The error message shown should be 'Please input a valid flag. These are the flags that are valid: [n/] [p/] [e/] [a/].'

Actual

The error message shown was 'At least 1 flag should be provided!'

Screenshot 2024-04-19 at 4.31.37 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#4834] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi thanks for the feedback!

We have specified in the UG under export command section that the app will only accept the 4 specified flags, other inputs (even if they contain a /) will not even be considered a flag.

According to the above, o/ is not considered a flag, just like how ooooooooooo/ should not be considered a flag, rather, it will only be an input containing a /.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: This is an easy-to-detect incorrect flag and you can give an error message. Despite mentioning only 4 types of flags would be detected, the error message can give inconvenience and it would be better to tell the user the typed in flag is wrong. Furthermore, if the flag is mistyped (for instance, the user wants all four flags but one of them is typed as g/ which is not supported) and the user doesn't get the expected result, the user may need to execute the command again.


❓ Issue type

Team chose [type.FunctionalityBug]
Originally [type.FeatureFlaw]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants