-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization issues #21
Comments
Do you have an example of this in another extension to take a look? I'm not sure how to do it yet but I will try to help you. Have you tried using your own translation with the 'FoF Linguist' extension? |
In hindsight I should have been more specific. My issue is that the code is reusing strings it should. In this case:
I think that the best course of action would be spelling out the whole string, and not try to optimize it, so By the way I fixed my issue with a workaround, so it's not like I am unable to translate the extension, it just would be better if I did not have to do this. PS: If you are still unsure what I mean, I can send you a PR. |
Thank you for such detailed information. If you don't mind, create a Draft PR and I will take a look. Also you could include a new .yaml file with your language to contain the best translation considering you are native (I guess). Next week I'll try to complete this issue to include a new string so we can work together on the same PR to fix both at the same time: |
These two strings are not great to translate:
jslirola-login2seeplus.forum.post:
flarum-ext-login2seeplus/js/src/forum/index.js
Line 65 in 14257e2
jslirola-login2seeplus.forum.post_login:
flarum-ext-login2seeplus/src/HideContentInPosts.php
Line 66 in 14257e2
In some languages (e.g. in Hungarian in my case) we would like to use conjugation/declension with the Log in and Register string, but currently this is not possible.
The text was updated successfully, but these errors were encountered: