Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text is wrong color in dark mode #429

Open
dmccallie opened this issue May 23, 2024 · 2 comments
Open

text is wrong color in dark mode #429

dmccallie opened this issue May 23, 2024 · 2 comments

Comments

@dmccallie
Copy link

Issue

In dark mode (as set by my window OS preference) any pre-existing blog text from the sample posts comes out as dark type on dark background. Text that is entered via the CKEditor appears to be OK (light on dark.)

Also, any text added directly to the blog post template (which I added as a debugging test) also comes out as dark text on dark background.

In other words, the text styling is not scoped to cover the whole blog post, but only covers the text captured by the CKEditor at the time that the background is known.

I haven't gotten deep enough into the code to understand where this is coming from, but I thought you should know.

Thanks.

@jsolly
Copy link
Owner

jsolly commented May 23, 2024

Ahh, Yeah that makes sense. When you use CKEditor, it's dumping formatted HTML into the database whereas when you seed posts with a script, they don't get any of that formatting.

Let me know what you find!

I would love to move away from CKeditor to something that authors mark, but I never had the time to do so.

@freedompraise
Copy link
Collaborator

Issue

In dark mode (as set by my window OS preference) any pre-existing blog text from the sample posts comes out as dark type on dark background. Text that is entered via the CKEditor appears to be OK (light on dark.)

Also, any text added directly to the blog post template (which I added as a debugging test) also comes out as dark text on dark background.

In other words, the text styling is not scoped to cover the whole blog post, but only covers the text captured by the CKEditor at the time that the background is known.

I haven't gotten deep enough into the code to understand where this is coming from, but I thought you should know.

Thanks.

Interesting. I remember coming across something similar sometime ago, but couldn't pinpoint what the issue was. It would be nice to see you come with something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants