Bug fixes in Examples (PR #5 for issue #94) #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkellogg please check this out when you have a moment 🙂 |
gkellogg
requested changes
Aug 13, 2023
spec/index.html
Outdated
| @@ -342,7 +342,7 @@ <h2>Introduction</h2> | |||
|
|
|||
| <div class="ednote"> | |||
| See YAML-LD description of this spec at | |||
| <a href="https://github.com/json-ld/yaml-ld/blob/main/spec/spec.yaml"> | |||
| <a href="https://github.com/json-ld/yaml-ld/blob/main/spec/data/spec.yaml" target="_blank"> | |||
There was a problem hiding this comment.
It's cleaner to keep these references as relative to the spec, so when they're published, they show up properly. That would make it <a href="data/spec.yaml">...</a>.
|
Done so, — but it would seem it does not render. For instance: https://pr-preview.s3.amazonaws.com/json-ld/yaml-ld/pull/data/spec.yaml does not work. |
PR Preview doesn't have access to associated files, but you can see them via GitHack. This better reflects how the spec will render when merged. |
gkellogg
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
YAML-LD samples have a few bugs.
What
This PR is fixing those.
Preview | Diff