-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancement: Blog header image alignment issue causing poor UX on JSON Schema blog page #1342
Comments
Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look at our contributors guide if you plan on opening a pull request. |
@DhairyaMajmudar please have a look into this |
@Vineet1101 The fonts are necessary and should not be removed as they are details of author and the blog title, Do you've any other fix for this ? |
@DhairyaMajmudar changing the object-fit from cover to fill, inherit, or initial would make this image look like this - The image looks stretched here. But changing the object-fit to contain or scale-down, would look like this - In this case, the image is not covering up the whole background. Actually, the issue is about the positioning of the logos on the background image. So, either we have to compromise with the image fitting or change the Image (which is not preferable ig) If you want to change the object-fit, then I can raise PR. Please let me know. |
Hey @swaparup36 I have already made the changes in my local and fixed the issue. I am working on this issue and will raise pr. Please can you look for another issue to solve |
@Vineet1101 sure |
Is your feature request related to a problem? Please describe
As in the image it can be clearly seen the images are not properly shown mainly the logo of json schema and gsoc has been cut which is not appealing to eyes
Describe the solution you'd like
To implement this feature, we would need to:
We can remove the font as I think it is not necessary or
Atleast show the proper logo
One more thing I would like to propose we can implement navbar to be not sticky
Additional context
No response
Are you working on this?
Yes
The text was updated successfully, but these errors were encountered: