Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Ui fixes in main page. #1273

Open
cbum-dev opened this issue Jan 10, 2025 · 9 comments · May be fixed by #1360
Open

🐛 Bug: Ui fixes in main page. #1273

cbum-dev opened this issue Jan 10, 2025 · 9 comments · May be fixed by #1360
Assignees
@cbum-dev
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@cbum-dev
Copy link
Contributor

Describe the bug

Ui issues in the homepage.

Steps To Reproduce

Go to homepage and scroll down to "Welcome to the JSON Schema Community" section their you can see several ui issues.

Expected Behavior

The alignment and placement of buttons and text should be proper.

Screenshots

image

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes
@cbum-dev cbum-dev added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jan 10, 2025
@github-actions GitHub Actions
Copy link

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look at our contributors guide if you plan on opening a pull request.
For more details, check out the README.md file.

@DhairyaMajmudar
Copy link
Member

@cbum-dev what kind of UI issues you're suggesting here ? Pls. give a bit description of them

@cbum-dev
Copy link
Contributor Author

image
basically this section is bit off in terms of spacing and styles.

@DhairyaMajmudar
Copy link
Member

How it can be improved, do you have new designs in your mind? Pls. share some screenshots

@cbum-dev
Copy link
Contributor Author

How it can be improved, do you have new designs in your mind? Pls. share some screenshots

I will share once its done.
I mean the idea was that they are looking little off, the imaging etc. I will share and ask in slack once its ready.

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Jan 12, 2025 •
edited
Loading

sure, looking forward for your ideas, do share them on slack's #website channel

@cbum-dev
Copy link
Contributor Author

sure, looking forward for your ideas, do share them on slack's #website channel

Hi @DhairyaMajmudar I am done with my designs.
Attaching here and slack as well.
Old:
Screenshot From 2025-01-10 12-38-46
Design proposal 1:
image
Design proposal 2:
image
Keeping in mind the design pattern of the existing website, this is what I created.
Looking forward to your response.

@cbum-dev
Copy link
Contributor Author

Hi @DhairyaMajmudar as Benja confirmed the second design. So please assign this issue to me to get started.

@DhairyaMajmudar
Copy link
Member

Go ahead @cbum-dev

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 19, 2025
@cbum-dev cbum-dev linked a pull request Jan 22, 2025 that will close this issue
Open
cbum-dev added a commit to cbum-dev/website that referenced this issue Jan 31, 2025
@cbum-dev
Merge branch 'main' into issues/json-schema-org#1273
3a44226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbum-dev cbum-dev

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Style changes in homepage cbum-dev/website
2 participants
@cbum-dev @DhairyaMajmudar