Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Navbar not active on tools page. #1375

Open
cbum-dev opened this issue Jan 25, 2025 · 12 comments
Open

🐛 Bug: Navbar not active on tools page. #1375

cbum-dev opened this issue Jan 25, 2025 · 12 comments
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue.

Comments

@cbum-dev
Copy link
Contributor

Describe the bug

While navigating to tools page and its related sub-page the navbar is not active.
The pages under blogs and other pages should also make the navbar active with "/blog".

Steps To Reproduce

Go to https://json-schema.org/tools and see the navbar

Expected Behavior

The tools should be in active state.

Screenshots

Screencast.From.2025-01-25.17-57-06.mp4

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

Yes

@cbum-dev cbum-dev added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jan 25, 2025
@jagpreetrahi
Copy link

Hey @cbum-dev , I hope you doing well, can you elaborate more about this issue , what should be expected there, I have seen your providing video, i am not able to understand that

@cbum-dev
Copy link
Contributor Author

Hey @cbum-dev , I hope you doing well, can you elaborate more about this issue , what should be expected there, I have seen your providing video, i am not able to understand that

Like its related to navbar active state. Clicking on tooling page will not activate the navbar "eg: not underlining the tools navigation"

@jagpreetrahi
Copy link

Ok , I got it

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Jan 27, 2025

Navbar is inactive in light mode for all links. while in dark mode for tools link.

@DhairyaMajmudar DhairyaMajmudar added Status: Available No one has claimed responsibility for resolving this issue. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 27, 2025
@jagpreetrahi
Copy link

Hey @DhairyaMajmudar, I hope you're doing well. I would love to work on this issue if it's possible. Could you please assign it to me?

@cbum-dev
Copy link
Contributor Author

@jagpreetrahi I have already fixed this issue. Maybe you should work on some other issues. But I would love to see your approach towards this issue. 🚀

@jagpreetrahi
Copy link

Hey @cbum-dev, amazing resolving the issue so quickly , and it’s been a pleasure understanding the issue alongside you.

@cbum-dev
Copy link
Contributor Author

Hey @cbum-dev, amazing resolving the issue so quickly , and it’s been a pleasure understanding the issue alongside you.

Its been 3 days since I opened it 😅😅. But thanks.

@cbum-dev
Copy link
Contributor Author

@DhairyaMajmudar Please assign this to me.

@jagpreetrahi
Copy link

Hey @cbum-dev , can you please provide me the details where you exactly found that bug inside the file, bcz you told that like already had fixed issue.

@cbum-dev
Copy link
Contributor Author

cbum-dev commented Feb 1, 2025

@DhairyaMajmudar Can you please assign it to me as this is an "accepted" issue.

@cbum-dev
Copy link
Contributor Author

cbum-dev commented Feb 1, 2025

Hey @cbum-dev , can you please provide me the details where you exactly found that bug inside the file, bcz you told that like already had fixed issue.

Mainly on the navbar component and some other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Available No one has claimed responsibility for resolving this issue.
Projects
Status: No status
Development

No branches or pull requests

3 participants