Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enhancement: Create a Reusable UI Button Component #1396

Closed
smartcraze opened this issue Feb 3, 2025 · 2 comments
Closed

✨ Enhancement: Create a Reusable UI Button Component #1396

smartcraze opened this issue Feb 3, 2025 · 2 comments
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage.

Comments

@smartcraze
Copy link

Is your feature request related to a problem? Please describe

  1. Current Problem:
    Yes, the current button implementation forces developers to manually add class names, which causes inconsistent designs and makes maintenance harder.

  2. Code Duplication:
    It creates a heavy codebase with repeated code instead of using a reusable component.

  3. Risk of Style Divergence:
    This increases the risk of style differences across the app.

  4. Complicated Future Updates:
    It makes future updates more difficult, as each button would need to be adjusted individually.

Describe the solution you'd like

  1. Reusable Button Component:
    Create a single reusable Button component that can be easily customized through props for different variants and sizes.

  2. Consistent Styling:
    Ensure that the component enforces consistent button styling across the app by handling class names internally.

  3. Simplified Codebase:
    Reduce code duplication by using this component instead of manually adding class names every time a button is needed.

  4. Ease of Maintenance:
    Make future updates easier by modifying the button styles in one place, rather than updating each button instance individually across the app.

Describe alternatives you've considered

Additional Notes

  • Currently, I have implemented the Button component, but if assigned, I can create more reusable components to reduce complications and improve maintainability.

Additional context

No response

Are you working on this?

Yes

@smartcraze smartcraze added Status: Triage This is the initial status for an issue that requires triage. ✨ Enhancement Indicates that the issue suggests an improvement or new feature. labels Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look at our contributors guide if you plan on opening a pull request.
For more details, check out the README.md file.

@DhairyaMajmudar
Copy link
Member

@smartcraze thanks for opening the issue we are already in talks of using a UI component library where this issue will be resolved.

@DhairyaMajmudar DhairyaMajmudar closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants