Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionable permission level #138

Open
shaedrich opened this issue Jul 24, 2024 · 7 comments
Open

Questionable permission level #138

shaedrich opened this issue Jul 24, 2024 · 7 comments

Comments

@shaedrich
Copy link
Contributor

What do you need that excessive permissions for? I thought, you just need to read from a simple gist?

grafik

@thomasdavis
Copy link
Member

Thanks for the report. It should only need;

  • read and write public gist
  • read user profile

The current permissions are set here -> https://github.com/jsonresume/jsonresume.org/blob/master/apps/registry/auth.js#L12

I will check it out later if no one else knows how to reduce those permissions

@thomasdavis
Copy link
Member

Just need to change it to read:user for read only user.

But I don't think it's possible to scope it to public gist only

@shaedrich
Copy link
Contributor Author

@thomasdavis
Copy link
Member

Yeah but it doesn't support writing gist which is needed for the editor

@shaedrich
Copy link
Contributor Author

Ah, okay. You are right. This would need the gist permission then

@thomasdavis
Copy link
Member

I've updated it to just read user profile in this commit 8e5b9dc

Will keep this open for a little while to see if anyone has any good ideas to let people keep their gists private.

@shaedrich
Copy link
Contributor Author

Awesome! Thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants