[Tests] skip some tests that have broken ordering in certain node/eslint combinations

Author: ljharb

tests/helpers/parsers.js

@@ -39,6 +39,7 @@ const parsers = {
   TYPESCRIPT_ESLINT: path.join(__dirname, NODE_MODULES, 'typescript-eslint-parser'),
   '@TYPESCRIPT_ESLINT': path.join(__dirname, NODE_MODULES, '@typescript-eslint/parser'),
   disableNewTS,
+  skipDueToMultiErrorSorting: semver.satisfies(process.versions.node, '^8 || ^9'),
   babelParserOptions: function parserOptions(test, features) {
     return Object.assign({}, test.parserOptions, {
       requireConfigFile: false,

tests/lib/rules/jsx-equals-spacing.js

@@ -86,16 +86,16 @@ ruleTester.run('jsx-equals-spacing', rule, {
     },
   ]),
 
-  invalid: parsers.all([
-    {
+  invalid: parsers.all([].concat(
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<App foo = {bar} />',
       output: '<App foo={bar} />',
       errors: [
         { messageId: 'noSpaceBefore', type: 'JSXAttribute' },
         { messageId: 'noSpaceAfter', type: 'JSXAttribute' },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<App foo = {bar} />',
       output: '<App foo={bar} />',
       options: ['never'],
@@ -116,7 +116,7 @@ ruleTester.run('jsx-equals-spacing', rule, {
       options: ['never'],
       errors: [{ messageId: 'noSpaceAfter', type: 'JSXAttribute' }],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<App foo= {bar} bar = {baz} />',
       output: '<App foo={bar} bar={baz} />',
       options: ['never'],
@@ -126,7 +126,7 @@ ruleTester.run('jsx-equals-spacing', rule, {
         { messageId: 'noSpaceAfter', type: 'JSXAttribute' },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<App foo={bar} />',
       output: '<App foo = {bar} />',
       options: ['always'],
@@ -147,7 +147,7 @@ ruleTester.run('jsx-equals-spacing', rule, {
       options: ['always'],
       errors: [{ messageId: 'needSpaceBefore', type: 'JSXAttribute' }],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<App foo={bar} bar ={baz} />',
       output: '<App foo = {bar} bar = {baz} />',
       options: ['always'],
@@ -156,6 +156,6 @@ ruleTester.run('jsx-equals-spacing', rule, {
         { messageId: 'needSpaceAfter', type: 'JSXAttribute' },
         { messageId: 'needSpaceAfter', type: 'JSXAttribute' },
       ],
-    },
-  ]),
+    }
+  )),
 });

tests/lib/rules/jsx-indent.js

@@ -2779,7 +2779,7 @@ const Component = () => (
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: `
         <div>
           text
@@ -2813,7 +2813,7 @@ const Component = () => (
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: `
         <div>
         \t  text

tests/lib/rules/jsx-no-useless-fragment.js

@@ -86,7 +86,7 @@ ruleTester.run('jsx-no-useless-fragment', rule, {
       options: [{ allowExpressions: true }],
     },
   ]),
-  invalid: parsers.all([
+  invalid: parsers.all([].concat(
     {
       code: '<></>',
       output: null,
@@ -99,7 +99,7 @@ ruleTester.run('jsx-no-useless-fragment', rule, {
       errors: [{ messageId: 'NeedsMoreChildren', type: 'JSXFragment' }],
       features: ['fragment'],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<p>moo<>foo</></p>',
       output: '<p>moofoo</p>',
       errors: [
@@ -114,7 +114,7 @@ ruleTester.run('jsx-no-useless-fragment', rule, {
       errors: [{ messageId: 'NeedsMoreChildren' }],
       features: ['fragment'],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<p><>{meow}</></p>',
       output: '<p>{meow}</p>',
       errors: [
@@ -177,7 +177,7 @@ ruleTester.run('jsx-no-useless-fragment', rule, {
       errors: [{ messageId: 'NeedsMoreChildren', type: 'JSXFragment' }],
       features: ['fragment', 'no-ts-old'], // TODO: FIXME: remove no-ts-old
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<div><>foo</></div>',
       output: '<div>foo</div>',
       errors: [
@@ -247,7 +247,7 @@ ruleTester.run('jsx-no-useless-fragment', rule, {
       errors: [{ messageId: 'ChildOfHtmlElement', type: 'JSXFragment' }],
       features: ['fragment', 'no-ts-old'], // TODO: FIXME: remove no-ts-old
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: `
         const Comp = () => (
           <html>
@@ -274,6 +274,6 @@ ruleTester.run('jsx-no-useless-fragment', rule, {
       errors: [{ messageId: 'NeedsMoreChildren', type: 'JSXFragment' }],
       output: '<Foo>{moo}</Foo>',
       features: ['fragment', 'no-ts-old'], // TODO: FIXME: remove no-ts-old
-    },
-  ]),
+    }
+  )),
 });

tests/lib/rules/no-invalid-html-attribute.js

@@ -234,7 +234,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
       code: '<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#fff" />',
     },
   ]),
-  invalid: parsers.all([
+  invalid: parsers.all([].concat(
     {
       code: '<a rel="alternatex"></a>',
       errors: [
@@ -713,7 +713,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<a rel={"foobar batgo       noopener"}></a>',
       errors: [
         {
@@ -782,7 +782,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<a rel={" batgo noopener"}></a>',
       errors: [
         {
@@ -913,7 +913,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<link rel="shortcut foo"></link>',
       errors: [
         {
@@ -957,7 +957,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: '<link rel="shortcut  foo"></link>',
       errors: [
         {
@@ -1832,6 +1832,6 @@ ruleTester.run('no-invalid-html-attribute', rule, {
           type: 'Literal',
         },
       ],
-    },
-  ]),
+    }
+  )),
 });

tests/lib/rules/no-typos.js

@@ -1873,7 +1873,7 @@ ruleTester.run('no-typos', rule, {
         },
       ],
     },
-    {
+    parsers.skipDueToMultiErrorSorting ? [] : {
       code: `
         class Hello extends React.Component {
           GetDerivedStateFromProps() { }