Fix jsx-no-target-blank crash (fixes #821)

Author: yannickcr

lib/rules/jsx-no-target-blank.js

@@ -25,13 +25,17 @@ module.exports = {
           return;
         }
 
-        if (node.name.name === 'target' && node.value.value.toLowerCase() === '_blank') {
+        if (
+          node.name.name === 'target' &&
+          node.value.type === 'Literal' &&
+          node.value.value.toLowerCase() === '_blank'
+        ) {
           var relFound = false;
           var attrs = node.parent.attributes;
           for (var idx in attrs) {
             if (attrs[idx].name && attrs[idx].name.name === 'rel') {
-              var tags = attrs[idx].value.value.toLowerCase().split(' ');
-              if (tags.indexOf('noopener') >= 0 && tags.indexOf('noreferrer') >= 0) {
+              var tags = attrs[idx].value.type === 'Literal' && attrs[idx].value.value.toLowerCase().split(' ');
+              if (!tags || (tags.indexOf('noopener') >= 0 && tags.indexOf('noreferrer') >= 0)) {
                 relFound = true;
                 break;
               }

tests/lib/rules/jsx-no-target-blank.js

@@ -31,7 +31,9 @@ ruleTester.run('jsx-no-target-blank', rule, {
     {code: '<a target="_blank" {...spreadProps} rel="noopener noreferrer"></a>', parserOptions: parserOptions},
     {code: '<a target="_blank" rel="noopener noreferrer" {...spreadProps}></a>', parserOptions: parserOptions},
     {code: '<p target="_blank"></p>', parserOptions: parserOptions},
-    {code: '<a href="foobar" target="_BLANK" rel="NOOPENER noreferrer"></a>', parserOptions: parserOptions}
+    {code: '<a href="foobar" target="_BLANK" rel="NOOPENER noreferrer"></a>', parserOptions: parserOptions},
+    {code: '<a target="_blank" rel={relValue}></a>', parserOptions: parserOptions},
+    {code: '<a target={targetValue} rel="noopener noreferrer"></a>', parserOptions: parserOptions}
   ],
   invalid: [
     {code: '<a target="_blank"></a>', parserOptions: parserOptions,