Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin loading on login page #9

Open
aacunha opened this issue Dec 13, 2017 · 6 comments
Open

Plugin loading on login page #9

aacunha opened this issue Dec 13, 2017 · 6 comments

Comments

@aacunha
Copy link

aacunha commented Dec 13, 2017

Dmitry,

I have tried to make an adjustment in the plugin for my reality, but I did not succeed. I use 2 authentication plugins, rcguard (https://plugins.roundcube.net/packages/dsoares/rcguard) and twofactor auth (https://plugins.roundcube.net/packages/alexandregz/twofactor_gauthenticator).

What I would like is that the plugin only start after opening the webmail ("mail" page). I explain why:

Captcha: If the user misses the password a few times the captcha is displayed. After this if it hits the password and does not validate the captcha the jsxc is loaded.

image

Two Factor: After the user authenticates, if the browser does not have the option to save active, the two factor field (login page) will be displayed, and jsxc will start.

image 1

I tried not to load jsxc through the jsxc.php file:

         case 'login':
             // $ this-> load_jsxc ();
             break;

But this way jsxc does not authenticate. I know it's not a malfunction of the plugin, but I believe it to be an improvement for the same.

Another case which happens exporadically, on the first login (no another connection on webmail or xmpp server), the jsxc loads on login page without connection:
captura de tela de 2017-12-13 09 51 49

Regards,
André

@sualko
Copy link
Member

sualko commented Dec 21, 2017

cc @dteleguin , ref #8

@aacunha
Copy link
Author

aacunha commented Mar 12, 2018

Dears,

one situation is occurring even without active third-party authentication plugins. If the user closes the browser with roundcube open (authenticated jsxc plugin). After that, even after a few minutes, when opening the browser and accessing the roundcube, already on the home page of the roundcube (login form), the jsxc restores its previous session, even before it was authenticated in the roundcube. How to avoid this situation?

I tested on chrome and in firefox.
captura de tela de 2018-03-12 16 19 29

@sualko
Copy link
Member

sualko commented Mar 15, 2018

You could use the displayRosterMinimized option to hide the roster, like this is done in Nextcloud. See,
https://github.com/nextcloud/jsxc.nextcloud/blob/d373e0befe376286719e901bdd65f9d4bebda999/js/ojsxc.js#L370-L372

@aacunha
Copy link
Author

aacunha commented Mar 15, 2018

@sualko , i see on jsxc.js and jsxc.min.js already has occurrences of displayRosterMinimized. I tried to use the function without success. Where can i add the function?

@sualko
Copy link
Member

sualko commented Mar 16, 2018

I think you can add it at https://github.com/jsxc/jsxc.roundcube/blob/master/jsxc.php#L60

@mckaygerhard
Copy link

this is solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants