diff --git a/CHANGELOG.md b/CHANGELOG.md index 0d0b4574..2f564407 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ ## Version 2.1 +* [bug fix] AddThis div container #295 +* [enhancement] Hide AddThis on non content pages by disabling - +
printTrail(); ?> - + data['isarticle'] && $wgForegroundFeatures['addThisPUBID'] !== '') { ?> + + diff --git a/README.md b/README.md index e3a828f4..c9ca352a 100644 --- a/README.md +++ b/README.md @@ -43,8 +43,10 @@ Use following features in `LocalSettings.php` to change the behavior. - `wikiName => 'Alternate WikiName'` sets top navbar name to a different output of the wiki's name. Useful if your `$wgSitename` is long but need to keep it for other purposes. - `navbarIcon => true` to display an icon in the top navbar. See below for more information. - `IeEdgeCode => 1` will produce a meta tag with "X-UA-Compatible" content="IE=edge", `2` will sent a header, `0` nothing will be done -- `showFooterIcons => 0` suppresses the output of footer icons. Set to `true` or `1` to display them. -- `addThisFollowPUBID => 'your-id'` add an id to display Follow Us horizontal bar of icons from various social media sites available on [addThis](https://addthis.com). +- `showFooterIcons => false` suppresses the output of footer icons. Set to `true` or `1` to display them. +- `addThisPUBID => ''` empty string will not fire the AddThis script, `'ra-##-#######'` publisher ID will allow the run the AddThis script in async on content pages only. +- `useAddThisShare => ''` default empty string, do not use AddThis share, `your_addthis_specific_div_class_string` will insert the share toolbox div directly under page title, but before the tagline with your custom div class. +- `useAddThisFollow => ''` default empty string, do not use AddThis follow, `your_addthis_specific_div_class_string` will insert the follow toolbox div in the `footer` area before icon or text output with your custom div class. These are the default values: @@ -57,8 +59,10 @@ These are the default values: 'wikiName' => &$GLOBALS['wgSitename'], 'navbarIcon' => false, 'IeEdgeCode' => 1, - 'showFooterIcons' => 0, - 'addThisFollowPUBID' => '' + 'showFooterIcons' => false, + 'addThisPUBID' => '', + 'useAddThisShare' => '', + 'useAddThisFollow' => '' ); ### Usage of NavWrapperType diff --git a/assets/stylesheets/foreground-print.css b/assets/stylesheets/foreground-print.css index 804c96c1..6c0ce864 100644 --- a/assets/stylesheets/foreground-print.css +++ b/assets/stylesheets/foreground-print.css @@ -1,6 +1,6 @@ -/* Show what will print */ +/* Control what will print */ -@media screen { +@media print { /* stop double border at bottom with print */ footer.row { border: none; @@ -29,37 +29,7 @@ nav { display: none !important; } -} - -/* Print what is shown */ - -@media print { - /* stop double border at bottom with print */ - footer.row { - border: none; - } - /*make namespace labels stand out */ - h4.namespace.label { - padding: 0.25em; - font-size: 1.4em !important; - font-weight: normal; - background-color: #777777 !important; - color: #fff !important; - } - /* hide actions button as it is not needed */ - #p-cactions a.button.dropdown.small.secondary.radius { - display: none !important; - } - /* if addThis share is used, make sure to hide mobile content from js */ - #at4m-dock, .at4-show, - #atstbx { - display: none !important; - } - /* hide Echo if being used */ - #echo-notifications { - display: none !important; - } - nav { + a#actions-button { display: none !important; } } diff --git a/assets/stylesheets/foreground.css b/assets/stylesheets/foreground.css index 68561c27..e47ddc6e 100644 --- a/assets/stylesheets/foreground.css +++ b/assets/stylesheets/foreground.css @@ -240,35 +240,10 @@ footer.row ul.views.columns li { list-style-type: none; } -/* Make social footer center need overflow:hidden and other div classes */ - -.social-footer { - margin: 0 0 1em; - font-size: 90%; - overflow: hidden; -} - -/* Hide all text in p elements */ - -.social-footer p { - display: none; -} - -/* Outer wrap */ - -.social-links { - position: relative; - left: 50%; - float: left; -} +/* Make social follow float right */ -/* addThis container (inner wrap) */ - -.addthis_horizontal_follow_toolbox { - position: relative; - left: -50%; - float: left; - z-index: 100000; +.social-follow { + float: right; } /* end social footer classes */ diff --git a/skin.json b/skin.json index 4bc3f074..ae3231e7 100644 --- a/skin.json +++ b/skin.json @@ -1,6 +1,6 @@ { "name": "Foreground", - "version": "2.1.0-beta", + "version": "2.1.0-rc", "author": [ "Garrick Van Buren", "Jamie Thingelstad",