Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Pop up on Semantic Forms not working #208

Open
CJTharp opened this issue Dec 11, 2014 · 6 comments
Open

Pop up on Semantic Forms not working #208

CJTharp opened this issue Dec 11, 2014 · 6 comments
Labels

Comments

@CJTharp
Copy link

CJTharp commented Dec 11, 2014

The popup function with a semantic form doesn't function correctly. It brings up the popup, but the popup is extra, extra small. The only thing problem I see in the console is it says the property length is undefined. Yaron Koren looked at it, but he's unsure of the specific Javascript or css causing the problem. And more unfortunately he said the Javascript inside Semantic Forms doing the popup is a third party deal that can't really be changed. The problem only happens inside the Foundation skin -- it works fine inside Vector.

@Hutchy68
Copy link
Collaborator

Can you provide a link to a page to view the issue?

@CJTharp
Copy link
Author

CJTharp commented Dec 11, 2014

Hi sorry for delay. I currently have a test site up with it at: http://54.144.201.169/mediawiki/Main_Page. I set up the example on the front page there. Currently only the Map Icon or the Map button is hooked up to a semantic form that popups. I'll leave this site live for the day. All the best to you.

@Hutchy68
Copy link
Collaborator

Will need to ask Yaron why the popup is the entire page. I don't think it is supposed to be the entire site within the form popup. I think it is only supposed to be the actual body content on the page, which is why I think there is a problem.

@yaronkoren
Copy link

Hi, this is Yaron. It's true that the contents within the popup are the entire page, as opposed to just the HTML of the form. That's not supposed to happen, and I don't know why it's happening there - maybe it's somehow due to the skin? The code calls $wgOut->disableHeaders(), which normally makes the skin part go away. I also don't know if that problem is connected to the popup appearing too small, though it's certainly a reasonable theory.

@Hutchy68 Hutchy68 added the bug label Dec 12, 2014
@Hutchy68
Copy link
Collaborator

Thanks @yaronkoren. I think it's reasonable to guess the issue is the disable headers isn't working for some reason against foreground. I see the bootstrap had a similar bug and the added a id="content" to a html5 tag of

which wraps the page output.

What version of MW is this? Semantic Forms?

@CJTharp
Copy link
Author

CJTharp commented Dec 16, 2014

Hi

Sorry for the delay.I was traveling.

The version of MW is 1.23.6 and the Semantic Forms version is 3.0.

On Sun, Dec 14, 2014 at 8:50 PM, Tom Hutchison [email protected]
wrote:

Thanks @yaronkoren https://github.com/yaronkoren. I think it's
reasonable to guess the issue is the disable headers isn't working for some
reason against foreground. I see the bootstrap had a similar bug and the
added a id="content" to a html5 tag of which wraps the page output.

What version of MW is this? Semantic Forms?


Reply to this email directly or view it on GitHub
#208 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants