Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Updating foreground.wikiproject.net to 2.1.0-xxx #311

Closed
kghbln opened this issue Dec 26, 2017 · 16 comments
Closed

Updating foreground.wikiproject.net to 2.1.0-xxx #311

kghbln opened this issue Dec 26, 2017 · 16 comments

Comments

@kghbln
Copy link
Contributor

kghbln commented Dec 26, 2017

@Hutchy68 I guess I should upgrade the wiki to 2.1.0-alpha. There we/I could test #302 but also some other CSS tweaks I have in mind and fire away the release right after. Thoughts?

@Hutchy68
Copy link
Collaborator

Yes, go for it. I'm prepping 2.1-beta right now

@Hutchy68
Copy link
Collaborator

Beta released, I still need to address these issues to clear for the 2.0 milestone. I will by Saturday have them all addressed and release Beta 2. @kghbln if you have any CSS updates, please start PR'ing them at develop branch and I'll merge them in. Thanks!

@kghbln
Copy link
Contributor Author

kghbln commented Dec 30, 2017

@Hutchy68 I just updated the skin and changed the default setting to what is shown on the features page I just created. This page still need some work as well as other docu pages like the one on tabs.

@Hutchy68
Copy link
Collaborator

Did you turn tabs on because default is set the false?

@kghbln
Copy link
Contributor Author

kghbln commented Dec 31, 2017

Did you turn tabs on because default is set the false?

No but is should if we would like to demo something. Still the tabs will not work here since the page is still using Foundation 4 syntax.

@Hutchy68
Copy link
Collaborator

Ok, the page for tabs is updated using Foundation 5 syntax.

@kghbln
Copy link
Contributor Author

kghbln commented Dec 31, 2017

Cool, thanks a lot. I just updated the configuration page a bit. As soon as addthis is in fluff I will do final work on the page.

@kghbln
Copy link
Contributor Author

kghbln commented Feb 13, 2018

@Hutchy68 The wiki is now at 2.1.0-rc Also switched over to use AddThis via Foreground and not via PCRGUIInserts as before.

@Hutchy68
Copy link
Collaborator

Awesome 😎

I see one little thing on footer-left to fix on mobile. I’ll create an issue.

@kghbln
Copy link
Contributor Author

kghbln commented Feb 14, 2018

You are welcome.

I have created the Page Title page which is also showing some general glitches that imho should be tackled:

  • Header 2 is bigger in font size that the page title
  • Listing and Enumeration headers have a rather large margin to the bottom
  • Enumerations have an indentation that should be much smaller
  • Listings have an indentation that is too small
  • Headers should in general have a larger margin to the top

@Hutchy68
Copy link
Collaborator

  • Header 2 is bigger in font size that the page title
  • Listing and Enumeration headers have a rather large margin to the bottom
  • Enumerations have an indentation that should be much smaller
  • Listings have an indentation that is too small
  • Headers should in general have a larger margin to the top

@kghbln I addressed these issues as best as I could. MW is loading a legacy.module with CSS for elements. Real pain in the neck! Anyway, I merged in #322 so you can PULL down the changes on foreground.wikiproject.net and take a look. Here is a snip of my test installation with your source page code. firstHeading was just a reverse of @media screen size call. Fixed that too.

image

@kghbln
Copy link
Contributor Author

kghbln commented Feb 14, 2018

@Hutchy68 Thanks a lot. Just moved in "rc.1" and is really looks great again! :)

@kghbln
Copy link
Contributor Author

kghbln commented Feb 14, 2018

Hmm, sublevel enumerations and listings could perhaps be tweaked a bit? However, this is a nitpick.

@kghbln kghbln changed the title Updating foreground.wikiproject.net Updating foreground.wikiproject.net to 2.1.0-xxx Feb 14, 2018
@Hutchy68
Copy link
Collaborator

Hmm, sublevel enumerations and listings could perhaps be tweaked a bit? However, this is a nitpick.

That's going to be a hard one.

FYI, MW is outputting a shared css module to all skins. There is an open tracker on Phabricator here: https://phabricator.wikimedia.org/T89981

This is everything being loaded automatically 😞 by all skins.

https://gist.github.com/Hutchy68/a2e6220ee471210aa522f4762df1dc06

@kghbln
Copy link
Contributor Author

kghbln commented Feb 14, 2018

Ah, now I get it. Thanks for the insight. In fifteen years I have only seen something like this twice so we should not worries about this too much. The fixes of today are a big jump forward.

@Hutchy68
Copy link
Collaborator

Closing as not relevant any longer

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants