Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

[feature] adding autocapitalize attribute to search bar #377

Open
Rififia opened this issue Oct 24, 2020 · 7 comments
Open

[feature] adding autocapitalize attribute to search bar #377

Rififia opened this issue Oct 24, 2020 · 7 comments

Comments

@Rififia
Copy link
Contributor

Rififia commented Oct 24, 2020

Setup

  • Browsers and versions: Mobile browsers supporting autocapitalize attribute
  • Foreground version: 2.3.0

Issue

Some wikis (e.g. dictionnaries like the wiktionnary) have $wgCapitalLinks set to false and lower-case titles.
Therefore, searching articles with mobile and autocapitalization enabled may be annoying as you always need to make the first letter lower case.

That's why it would be great to add a feature that allows modifying the attribute autocapitalize on the search bar, especially to set it to off.

@Rififia
Copy link
Contributor Author

Rififia commented Oct 24, 2020

See also https://gerrit.wikimedia.org/r/c/mediawiki/core/+/635286/2/includes/skins/Skin.php#b2445, they are working on a fix for the latest version of MediaWiki to make autocapitalizing disabled when $wgCapitalLinks is set to false.

@Hutchy68
Copy link
Collaborator

Is this still needed or should we wait until 1.35.1 is released and see if it is merged?

@Rififia
Copy link
Contributor Author

Rififia commented Jan 2, 2021

Hi, sorry for the delay. So 1.35.1 is released and this fix has been merged but I didn't make the update, I will do it and see if it's fixed now in mw's core (but there is no reason it won't be).
So yes this issue will be useless except for old mw versions.

@Rififia
Copy link
Contributor Author

Rififia commented Mar 3, 2021

The fix is sill not merged in an official release, but it is on the 1.36 beta. Wikimedia's wiki have this functionnality.
It may not worth implementing, except for backward compatibility I guess. As you wish, maybe not on the version for 1.35+ ?
https://phabricator.wikimedia.org/T251664 is the phabricator's task, but it looks like it's frozen.

@Hutchy68
Copy link
Collaborator

Hutchy68 commented Mar 4, 2021

Ok, I’ll take a look but it will be a few days. I’m getting slammed by work.

@Rififia
Copy link
Contributor Author

Rififia commented Mar 8, 2021

Don't worry there is time, I still need to make a small change (I don't actually think we need to add a new parameter, just a single check of wgCapitalLinks will make it works for most case).

@Rififia
Copy link
Contributor Author

Rififia commented Apr 5, 2021

I've updated, using a simpler code… but I failed to pass one of the test, I don't know why

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants