Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Broken with Mediawiki 1.37.1 [solved] #395

Open
fw25 opened this issue Mar 10, 2022 · 5 comments
Open

Broken with Mediawiki 1.37.1 [solved] #395

fw25 opened this issue Mar 10, 2022 · 5 comments

Comments

@fw25
Copy link
Contributor

fw25 commented Mar 10, 2022

Setup

  • Browsers and versions: Firefox 78, Brave 1.36.111 and Chrome 99.0.4844.51
  • MediaWiki version: 1.37.1
  • Database version: 5.5.68-MariaDB
  • PHP version: 7.4.28 (cgi-fcgi)
  • Foreground version: 2.4.1
  • Extension version (if connected to the issue):

Issue

Detailed description of the issue goes here.
There is an jquery error in a javascript file it is about url.indexOf. It cripples the internal links.
Screen Shot 2022-03-10 at 16 20 05

@fw25 fw25 changed the title Broken with 3.7.1 Broken with 1.37.1 Mar 10, 2022
@fw25 fw25 changed the title Broken with 1.37.1 Broken with Mediawiki 1.37.1 Mar 10, 2022
@fw25
Copy link
Contributor Author

fw25 commented Mar 11, 2022

There is a simple workaround.
Replace load with on(“load”

assets/scripts/foundation/foundation.topbar.js
replace in line 248
}, 50)).trigger('resize.fndtn.topbar').load(function () {
with
}, 50)).trigger('resize.fndtn.topbar’).on(“load”,function () {

assets/scripts/foundation/foundation.js
replace line 345
S(window).load(function () {
with
S(window).on("load",function () {

@fw25 fw25 changed the title Broken with Mediawiki 1.37.1 Broken with Mediawiki 1.37.1 [solved] Mar 12, 2022
@racribeiro
Copy link

Yes, this works.

Please consider pushing this change to the repository.

@Hutchy68
Copy link
Collaborator

Hutchy68 commented Jun 3, 2022

If someone opens a pr against develop branch I’ll merge.

@rebastion
Copy link

@fw25 it does give a "Uncaught SyntaxError: '' string literal contains an unescaped line break" error in the debugger though, did I copy paste something wrong?

@rebastion
Copy link

Works if done like this
82bbd15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants