Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matplotlib Requirement #267

Open
QuentinFuxa opened this issue Jan 19, 2025 · 1 comment
Open

Update matplotlib Requirement #267

QuentinFuxa opened this issue Jan 19, 2025 · 1 comment

Comments

@QuentinFuxa
Copy link

The current matplotlib version requirement in diart (matplotlib>=3.3.3,<3.6.0) is outdated and causes installation failures with Python 3.13 due to issues with building the matplotlib wheel: ERROR: Failed building wheel for matplotlib

Proposed Update:
I suggest raising the matplotlib version requirement to include more recent versions. I have tested the main functionalities of diart with the latest version of matplotlib, and they work correctly. You can see my implementation here: whisper_streaming_web.

Testing Notes:
While the main functionalities seem to work with the updated version, I have not tested the figure generation code at line 122 in dsrc/diart/sinks.py.

And thank you for maintaining this great project!

Quentin

@JakobHavtorn
Copy link
Contributor

JakobHavtorn commented Feb 3, 2025

We're experiencing similar issues when installing with Python 3.11.

<long trace of C compiler errors above>

  at ~/.local/pipx/venvs/poetry/lib/python3.13/site-packages/poetry/installation/chef.py:164 in _prepare
      160│ 
      161│                 error = ChefBuildError("\n\n".join(message_parts))
      162│ 
      163│             if error is not None:
    → 164│                 raise error from None
      165│ 
      166│             return path
      167│ 
      168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but 
with matplotlib (3.5.3) not supporting PEP 517 builds. You can verify this by running 
'pip wheel --no-cache-dir --use-pep517 "matplotlib (==3.5.3)"'.

Running pip wheel --no-cache-dir --use-pep517 "matplotlib (==3.5.3)" does indeed re-confirm the issue with matplotlib.

@juanmc2005 Is there backing for a PR that updates Python version support from 3.8-10 (3.8 is EOL and 3.9 has 9 months until EOL)? I have created one here #269.

@QuentinFuxa Do I understand you correctly that bumping Matplotlib to more recent versions allows installing diart with Python 3.13 without hiccups?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants