You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could it be considered to change from the current 0-1 to the more standard 0-255 scale for RGB colours?
This would make choosing a specific colour from an RGB Color Chart far more trivial than converting.
i've purposely picked a weird colour here as an example: For a light green, this would be R102,G255,B102. and i could then scale those numbers for brightness. I could simply type these numbers in to the config. While is is trivial to convert, i now have to convert to a 0-1 scale potentially multiple times per colour.
This could further be inproved upon with an addition of a seperate 'brightness:' state where i can statically define a colour (eg R255 G0 B0) and setting brightness to 0.5 would automatically change all defined RGB values in the [led_effect].
Using the idle example from the docs, this is how i'd envisage it would work. the result would be 'light shade of blue' at 50% brightness.
Colors from 0 to 1 is the Klipper way to define colors. But I was already thinking about supporting something like (#12FFAB). So it's on the backlog. Adding brightness is also possible, but I was thinking of making it a parameter for SET_LED_EFFECT.
Could it be considered to change from the current 0-1 to the more standard 0-255 scale for RGB colours?
This would make choosing a specific colour from an RGB Color Chart far more trivial than converting.
i've purposely picked a weird colour here as an example: For a light green, this would be R102,G255,B102. and i could then scale those numbers for brightness. I could simply type these numbers in to the config. While is is trivial to convert, i now have to convert to a 0-1 scale potentially multiple times per colour.
This could further be inproved upon with an addition of a seperate 'brightness:' state where i can statically define a colour (eg R255 G0 B0) and setting brightness to 0.5 would automatically change all defined RGB values in the [led_effect].
Using the idle example from the docs, this is how i'd envisage it would work. the result would be 'light shade of blue' at 50% brightness.
The text was updated successfully, but these errors were encountered: