Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace regex parser by a more robust implementation #1

Open
julien-duponchelle opened this issue Nov 20, 2018 · 1 comment
Open

Replace regex parser by a more robust implementation #1

julien-duponchelle opened this issue Nov 20, 2018 · 1 comment

Comments

@julien-duponchelle
Copy link
Owner

As soon vscode release:
Provide an API for advanced/semantic source highlighting
microsoft/vscode#585

We can publish a more robust implementation.

@polvalente
Copy link
Contributor

As discussed in #16, I think it may be time to move forward with this plan. At least, change things up a bit in the token matching functionality. There are some limitations imposed by the usage of \b tokens as word boundaries, and we also have some problems with multiple modes (such as ignore-blocks, single-line expressions and opening tokens being the same as closing tokens).

As such, I think maybe we could move to using an external library to do the parsing heavy-lifting. I'm not familiar with the JS tooling for this, but Jison seems like a good lead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants