Subtype AbstractBridgeOptimizer - #15
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
===========================================
- Coverage 72.77% 52.35% -20.42%
===========================================
Files 5 5
Lines 202 170 -32
===========================================
- Hits 147 89 -58
- Misses 55 81 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like this approach. We can reuse most of the logic of
AbstractBridgeOptimizerand we can implement our reformulation as bridges which has the additional advantage that users could also just useJuMP.add_bridgeto add our bridge to a JuMP model (but for that we'll have to complete the bridge implementation).We'll have some reformulation that break the constraint-wise assumption so for these the user will need to use our
ComplementOpt.Optimizerbut it's nice that for the simple use cases that don't need that, we can just have classical bridges