Skip to content

Subtype AbstractBridgeOptimizer - #15

Merged
blegat merged 3 commits into
mainfrom
bl/bridges
Jan 11, 2026
Merged

Subtype AbstractBridgeOptimizer#15
blegat merged 3 commits into
mainfrom
bl/bridges

Conversation

@blegat

@blegat blegat commented Jan 9, 2026

Copy link
Copy Markdown
Member

I like this approach. We can reuse most of the logic of AbstractBridgeOptimizer and we can implement our reformulation as bridges which has the additional advantage that users could also just use JuMP.add_bridge to add our bridge to a JuMP model (but for that we'll have to complete the bridge implementation).
We'll have some reformulation that break the constraint-wise assumption so for these the user will need to use our ComplementOpt.Optimizer but it's nice that for the simple use cases that don't need that, we can just have classical bridges

@codecov

codecov Bot commented Jan 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.35%. Comparing base (f6d8fbd) to head (58f41be).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/vertical.jl 86.36% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #15       +/-   ##
===========================================
- Coverage   72.77%   52.35%   -20.42%     
===========================================
  Files           5        5               
  Lines         202      170       -32     
===========================================
- Hits          147       89       -58     
- Misses         55       81       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blegat
blegat merged commit 0e1fabb into main Jan 11, 2026
4 of 5 checks passed
@odow
odow deleted the bl/bridges branch May 20, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant