Update to TestNG 7.10.0 fails

[sormuras]

As noted in

• Bump org.testng:testng from 7.9.0 to 7.10.0 in /junit5-multiple-engines junit5-samples#381 (comment)
  the method long[] getInstanceHashCodes() was removed from testng-core-api/src/main/java/org/testng/IClass.java.

That method is used by the testng-engine implementation here:

• testng-engine/src/main/java/org/junit/support/testng/engine/TestDescriptorFactory.java

  Line 71 in 75c75ea

  long[] instanceHashCodes = result.getTestClass().getInstanceHashCodes();

[krmahadevan]

@sormuras - This is now fixed as part of fixing testng-team/testng#3110

Once i get a confirmation from the user who logged the above mentioned issue, I will wrap up the release.

[marcphilipp]

@krmahadevan Thanks for the quick turnaround! 👍

[marcphilipp]

@krmahadevan Is there a replacement for the deprecated API that should be used instead?

[krmahadevan]

TestNG 7.10.1 is now available on Maven central https://repo1.maven.org/maven2/org/testng/testng/7.10.1/

[krmahadevan]

@krmahadevan Is there a replacement for the deprecated API that should be used instead?

No. That api was not serving any purpose from an end user perspective, because all it was doing was giving out hashCodes of the test class objects that were produced by each of the factory call invocations. That was why we moved all of them out from the public facing to internal, because they are still needed internal. I need to still sift through the codebase to see if they are still needed internally or not. It's like peeling onions :)

[marcphilipp]

Ok, so do you think it's fine if we keep using it here?

[krmahadevan]

It will be removed in the upcoming versions @marcphilipp

The TestNG codebase uses the same api but from an internal package. So it's needed internally, but it wont be available for TestNG consumers.

[marcphilipp]

We use it to compute the test class instance index which is appended to the display name:

testng-engine/src/main/java/org/junit/support/testng/engine/TestDescriptorFactory.java

Lines 70 to 82 in 5d5e0e7

	private static Integer getFactoryMethodInvocationIndex(ITestResult result) {
	long[] instanceHashCodes = result.getTestClass().getInstanceHashCodes();
	if (instanceHashCodes.length > 1) {
	long hashCode = result.getInstance().hashCode();
	for (int i = 0; i < instanceHashCodes.length; ++i) {
	if (instanceHashCodes[i] == hashCode) {
	return i;
	}
	}
	}
	return null;
	}

This is important to be able to differentiate between the different parameterized executions. Is there an undeprecated API that we can use to achieve the same?

[marcphilipp]

TestNG 7.10.1 is now available on Maven central repo1.maven.org/maven2/org/testng/testng/7.10.1

Could you please also publishing a new 7.11.0-SNAPSHOT to oss.sonatype.org?

[krmahadevan]

We use it to compute the test class instance index which is appended to the display name:

testng-engine/src/main/java/org/junit/support/testng/engine/TestDescriptorFactory.java

Lines 70 to 82 in 5d5e0e7

	private static Integer getFactoryMethodInvocationIndex(ITestResult result) {
	long[] instanceHashCodes = result.getTestClass().getInstanceHashCodes();
	if (instanceHashCodes.length > 1) {
	long hashCode = result.getInstance().hashCode();
	for (int i = 0; i < instanceHashCodes.length; ++i) {
	if (instanceHashCodes[i] == hashCode) {
	return i;
	}
	}
	}
	return null;
	}

This is important to be able to differentiate between the different parameterized executions. Is there an undeprecated API that we can use to achieve the same?

Ok. I will have to find out. Can this wait? If possible please log a bug so that I don't forget. Right now in the middle of an assignment that I need to wrap up within this week as part of an interview process.

Would want to first get that out of the way

[krmahadevan]

TestNG 7.10.1 is now available on Maven central repo1.maven.org/maven2/org/testng/testng/7.10.1

Could you please also publishing a new 7.11.0-SNAPSHOT to oss.sonatype.org?

Sure. I will do that in sometime.

[marcphilipp]

Ok. I will have to find out. Can this wait? If possible please log a bug so that I don't forget. Right now in the middle of an assignment that I need to wrap up within this week as part of an interview process.

Would want to first get that out of the way

Sure, no worries! I created testng-team/testng#3111

Could you please also publishing a new 7.11.0-SNAPSHOT to oss.sonatype.org?

Sure. I will do that in sometime.

I'll leave this issue open until that is done because I've configured the build to ignore the failing tests against the snapshot version for now which I'd like to revert:

testng-engine/build.gradle.kts

Line 212 in ef0bb1b

ignoreFailures = version.isSnapshot() // TODO remove this line once a new 7.11.0-SNAPSHOT artifact is available

[krmahadevan]

@marcphilipp - The next snapshot has been published https://oss.sonatype.org/content/repositories/snapshots/org/testng/testng/7.11.0-SNAPSHOT/