Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naas.pipeline() : Throw exception on error in production mode (scheduling) #371

Closed
FlorentLvr opened this issue Dec 23, 2022 · 0 comments · Fixed by #376
Closed

naas.pipeline() : Throw exception on error in production mode (scheduling) #371

FlorentLvr opened this issue Dec 23, 2022 · 0 comments · Fixed by #376
Assignees
@Dr0p42 @FlorentLvr
Labels
bug Something isn't working

Comments

@FlorentLvr
Copy link
Contributor

FlorentLvr commented Dec 23, 2022 •
edited
Loading

Pipeline execution is not stopped once there is an error on one of this NotebookStep().

If the pipeline is scheduled (production mode), the job status returned will be "👌 Completed" instead of "❌ Error"

The person in charge of this pipeline will have no clue to know something went wrong.
@jravenel jravenel moved this to 🔖 Ready in ⚡️ Product Roadmap Jan 5, 2023
@Dr0p42 Dr0p42 moved this from 🔖 Ready to 📋 Backlog in ⚡️ Product Roadmap Jan 6, 2023
@FlorentLvr FlorentLvr added the bug Something isn't working label Jan 7, 2023
@FlorentLvr FlorentLvr changed the title naas.pipeline() : Stop pipeline execution on error (if on_error not set) naas.pipeline() : Stop pipeline execution on error in production mode (scheduling) Jan 7, 2023
@Dr0p42 Dr0p42 changed the title naas.pipeline() : Stop pipeline execution on error in production mode (scheduling) naas.pipeline() : Throw exception on error in production mode (scheduling) Jan 19, 2023
@Dr0p42 Dr0p42 moved this from 📋 Backlog to 🔖 Ready in ⚡️ Product Roadmap Jan 19, 2023
@FlorentLvr FlorentLvr linked a pull request Jan 26, 2023 that will close this issue
fix: raise error if not self.on_error #376
Merged
@FlorentLvr FlorentLvr moved this from 🔖 Ready to 🏗 In progress in ⚡️ Product Roadmap Jan 26, 2023
@FlorentLvr FlorentLvr self-assigned this Jan 26, 2023
@jravenel jravenel moved this from 🏗 In progress to 👀 In review in ⚡️ Product Roadmap Jan 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in ⚡️ Product Roadmap Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dr0p42 Dr0p42

@FlorentLvr FlorentLvr

Labels
bug Something isn't working
Projects
⚡️ Product Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: raise error if not self.on_error jupyter-naas/naas
2 participants
@Dr0p42 @FlorentLvr