Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support token auth via query parameter #233

Closed
rolweber opened this issue Mar 8, 2017 · 1 comment · Fixed by #234
Closed

Support token auth via query parameter #233

rolweber opened this issue Mar 8, 2017 · 1 comment · Fixed by #234

Comments

@rolweber
Copy link
Contributor

rolweber commented Mar 8, 2017

As discussed in #211, token auth for web sockets requires the token to be passed as a query parameter rather than an Authorization header. This is independent of the token generation logic mentioned in #211, and compatible with the 1.x API.
@rolweber rolweber mentioned this issue Mar 8, 2017
Merged
@rolweber
Copy link
Contributor Author

rolweber commented Mar 8, 2017

See PR #234 against the current master.
I'll wait with a PR against 1.2.x until the one for 2.0 has been reviewed.

@rolweber rolweber mentioned this issue Mar 27, 2017
Merged
@camer314 camer314 mentioned this issue Apr 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Websocket auth with token as query param
1 participant
@rolweber