Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded igv database #3

Open
marimeireles opened this issue Jan 6, 2021 · 4 comments
Open

Hardcoded igv database #3

marimeireles opened this issue Jan 6, 2021 · 4 comments

Comments

@marimeireles
Copy link
Contributor

marimeireles commented Jan 6, 2021

We have the igv database hardcoded in the code as a json. I wonder how often it changes and if this should be dynamic and fetch it from somewhere?
Or if we should leave like it is.

PUBLIC_GENOMES_FILE = 'public_genomes.json'
@harrouet
Copy link
Contributor

harrouet commented Jan 6, 2021

public_genomes.json was taken from the public URL https://s3.amazonaws.com/igv.org.genomes/genomes.json, as indicated at the end of this documentation page.
I am not sure if it changes often, but I thought that it was not meant to be loaded each time a new notebook starts.
Ideally it would be better to have a cached version in the package, and check for new versions once in a while, e.g. if instantiating an unknown genome.

@marimeireles
Copy link
Contributor Author

Yeah! Seems like a good idea.
Thanks for the input @harrouet. I'm mainly creating these issues as a form to keep track on things I'm thinking.
I'm giving a review in ipyigv.

@harrouet
Copy link
Contributor

harrouet commented Jan 6, 2021

Sure, feel free to reach out in case of question!

@marimeireles
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants