-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating xeus #143
base: main
Are you sure you want to change the base?
updating xeus #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file xeus-sqliteConfig.cmake.in
can be clean up a bit, removing the cppzmq dependency. I haven't checked the CMakeLists.txt file, maybe some libraries / deps can be removed too.
@@ -7,15 +7,15 @@ dependencies: | |||
- cxx-compiler | |||
# Host dependencies | |||
- nlohmann_json | |||
- xtl | |||
- cppzmq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one can be removed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which one? xtl is beeing removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Johan means that cppzmq can be removed too
No description provided.