Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating xeus #143

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

DerThorsten
Copy link
Member

No description provided.

@DerThorsten DerThorsten marked this pull request as draft June 3, 2024 08:15
@DerThorsten DerThorsten marked this pull request as ready for review June 11, 2024 07:21
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file xeus-sqliteConfig.cmake.in can be clean up a bit, removing the cppzmq dependency. I haven't checked the CMakeLists.txt file, maybe some libraries / deps can be removed too.

@@ -7,15 +7,15 @@ dependencies:
- cxx-compiler
# Host dependencies
- nlohmann_json
- xtl
- cppzmq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one can be removed too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one? xtl is beeing removed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Johan means that cppzmq can be removed too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants