Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7: "Close tab" and "Close and Shutdown notebook" should be reworked. #6832

Closed
Carreau opened this issue Apr 5, 2023 · 7 comments · Fixed by #6843
Closed

v7: "Close tab" and "Close and Shutdown notebook" should be reworked. #6832

Carreau opened this issue Apr 5, 2023 · 7 comments · Fixed by #6843
Labels
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented Apr 5, 2023

They both close the widgets/lumino tabs, and not the browser tab.

The first one seem unnecessary, user can close browser tab.

The second make sens to shutdown the kernel, but should close the browse tab.

Screen Shot 2023-04-05 at 13 58 52

@Carreau Carreau added the bug label Apr 5, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 5, 2023
@Carreau
Copy link
Member Author

Carreau commented Apr 5, 2023

I'm going to add that "Kernel > Shutdown All kernels" make little sens in the menu if you have a single kernel / notebook per page...

@jtpio
Copy link
Member

jtpio commented Apr 5, 2023

Right. There should be an audit of the menu entries during the beta.

This is also related to #6398.

For reference it should be possible to hide some of these menu entries via the settings, for example like:

@jtpio
Copy link
Member

jtpio commented Apr 5, 2023

@Carreau maybe we could close this issue in favor of #6398?

@Carreau
Copy link
Member Author

Carreau commented Apr 5, 2023

Up to you, I think #6398 is a high level goal, while this one have explicit menus to fix, which might be easier to tackle one by one by new contributors. Up to you. Maybe make this a subtask of #6398 ?

@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Apr 5, 2023
@jtpio jtpio added this to the 7.0 milestone Apr 5, 2023
@jtpio
Copy link
Member

jtpio commented Apr 5, 2023

which might be easier to tackle one by one by new contributors

alright let's keep it open then.

@timmerk3
Copy link
Contributor

Hey, can I take this issue? I'm a new contributor so I'd like to try it out.

@jtpio
Copy link
Member

jtpio commented Apr 12, 2023

Sure thanks @timmerk3. Feel free to comment here if you need any help.

@jtpio jtpio linked a pull request Apr 20, 2023 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants