Merge pull request #1149 from gesiscss/launchretry

fix: launch retrying

Author: betatim

binderhub/builder.py

@@ -531,14 +531,8 @@ async def launch(self, kube, provider):
                                                     server_name=server_name,
                                                     repo_url=self.repo_url,
                                                     extra_args=extra_args)
-                duration = time.perf_counter() - launch_starttime
-                LAUNCH_TIME.labels(status="success", retries=i).observe(duration)
-                LAUNCH_COUNT.labels(
-                    status='success', **self.repo_metric_labels,
-                ).inc()
-                app_log.info("Launched %s in %.0fs", self.repo_url, duration)
-
             except Exception as e:
+                duration = time.perf_counter() - launch_starttime
                 if i + 1 == launcher.retries:
                     status = 'failure'
                 else:
@@ -580,6 +574,12 @@ async def launch(self, kube, provider):
                 continue
             else:
                 # success
+                duration = time.perf_counter() - launch_starttime
+                LAUNCH_TIME.labels(status="success", retries=i).observe(duration)
+                LAUNCH_COUNT.labels(
+                    status='success', **self.repo_metric_labels,
+                ).inc()
+                app_log.info("Launched %s in %.0fs", self.repo_url, duration)
                 break
         event = {
             'phase': 'ready',