-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 4 #59
Comments
Thank you for opening the issue. @andrii-i FWIW in |
Does the share link feature in This was also asked in jupyterlab/jupyter-collaboration#150 (comment) but I'm not sure about the status of it. |
It seems to be working fine with binder using https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab-4.0?urlpath=lab over at jupyterlab/jupyterlab-demo#115. It is a bit unexpected that the link sharing dialog opens by clicking at an icon in top right corner while this extension was adding a menu item (I was looking in the left collaboration panel and all over menus). |
Is this the usual Binder setup? |
Probably not. At some point it was used for the JupyterLab dev Binder by starting JupyterLav dev mode as a separate server via |
@krassowski, @jtpio, thank you for replies and looking into this. |
Description
Currently when trying to use with JupyterLab 4, errors out with
Reproduce
Attempt to use with JupyterLab 4
Expected behavior
Works with JupyterLab 4
Context
Trying to update dependencies in https://github.com/jupyterlab/jupyterlab-demo
The text was updated successfully, but these errors were encountered: