Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 4 #59

Open
andrii-i opened this issue May 31, 2023 · 6 comments
Open

Update to JupyterLab 4 #59

andrii-i opened this issue May 31, 2023 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@andrii-i
Copy link

Description

Currently when trying to use with JupyterLab 4, errors out with

The following packages are incompatible
├─ jupyterlab-link-share 0.3**  is installable and it requires
│  └─ jupyterlab >=3.0.0,<4 , which can be installed;

Reproduce

Attempt to use with JupyterLab 4

Expected behavior

Works with JupyterLab 4

Context

Trying to update dependencies in https://github.com/jupyterlab/jupyterlab-demo

@andrii-i andrii-i added the bug Something isn't working label May 31, 2023
@krassowski
Copy link

Thank you for opening the issue.

@andrii-i FWIW in jupyterlab-demo we can drop this extension as jupyterlab-collaboration will ship with its own way of sharing links (jupyterlab/jupyter-collaboration#150) so jupyterlab-link-share will no longer be required for RTC. I started this few days ago on a branch, please see my commits: https://github.com/jupyterlab/jupyterlab-demo/tree/lab-4.0 - the problem is that jupyterlab-collaboration has not been released yet (we can use alpha but I decided to just wait, and since then we got another alpha).

@jtpio
Copy link
Member

jtpio commented May 31, 2023

Does the share link feature in jupyter-collaboration work on Binder when there are two servers running with one proxied?

This was also asked in jupyterlab/jupyter-collaboration#150 (comment) but I'm not sure about the status of it.

@krassowski
Copy link

It seems to be working fine with binder using https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab-4.0?urlpath=lab over at jupyterlab/jupyterlab-demo#115. It is a bit unexpected that the link sharing dialog opens by clicking at an icon in top right corner while this extension was adding a menu item (I was looking in the left collaboration panel and all over menus).

@krassowski
Copy link

when there are two servers running with one proxied?

Is this the usual Binder setup?

@jtpio
Copy link
Member

jtpio commented May 31, 2023

Is this the usual Binder setup?

Probably not. At some point it was used for the JupyterLab dev Binder by starting JupyterLav dev mode as a separate server via jupyter-server-proxy. But I don't think this is the case anymore.

@andrii-i
Copy link
Author

@krassowski, @jtpio, thank you for replies and looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants