Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of the top-level version #114

Open
jtpio opened this issue Feb 21, 2024 · 1 comment · May be fixed by #122
Open

Fix handling of the top-level version #114

jtpio opened this issue Feb 21, 2024 · 1 comment · May be fixed by #122

Comments

@jtpio
Copy link
Member

jtpio commented Feb 21, 2024

Follow-up to #101

We still need a way to:

  • properly bump the top-level version here:

jupyterlab-topbar/package.json

Line 3 in 3744d60

"version": "1.0.0",

  • or version all the packages independently, and then use a date based version for the top-level (for example 2024.02.21)
@jtpio jtpio mentioned this issue Feb 21, 2024
Merged
@jtpio
Copy link
Member Author

jtpio commented Feb 22, 2024

This seems to be causing issues already, as noticed in https://github.com/jupyterlab-contrib/jupyterlab-topbar/actions/runs/8006108629/job/21867054874?pr=118

image

@jtpio jtpio mentioned this issue Feb 22, 2024
Merged
@jtpio jtpio linked a pull request Apr 8, 2024 that will close this issue
Add script to auto bump version in top level #122
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add script to auto bump version in top level mahendrapaipuri/jupyterlab-topbar
1 participant
@jtpio