Remove the dependency on jupyterlab
#1234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the dependency on
jupyterlab
was first added in #74.According to this PR and the git history, it seems it was likely more for convenience as installing
jupyter-ai
only withpip install jupyter-ai
would then automatically installjupyterlab
.However it looks like
jupyter-ai
does not make use of any Python import fromjupyterlab
when searching the code base: https://github.com/search?q=repo%3Ajupyterlab%2Fjupyter-ai%20jupyterlab&type=codeExcept for testing here:
jupyter-ai/packages/jupyter-ai/ui-tests/jupyter_server_test_config.py
Line 8 in fbc4895
Also generally JupyterLab extensions don't specify the dependency on
jupyterlab
by default in the extension template, so it's easier to install and reuse extensions in different contexts and environments. And JupyterLab users are already expected to have JupyterLab installed in their environment.Not having the dependency on
jupyterlab
will also make it easier to usejupyter-ai
with custom lab-based application that are not JupyterLab (but based onjupyterlab_server
).