Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Replace selection" checkbox #865

Open
dlqqq opened this issue Jun 30, 2024 · 0 comments
Open

Remove "Replace selection" checkbox #865

dlqqq opened this issue Jun 30, 2024 · 0 comments
Labels
enhancement New feature or request priority
Milestone

Comments

@dlqqq
Copy link
Collaborator

dlqqq commented Jun 30, 2024

Problem

Same as #864.

Current "replace selection" checkbox implementation is likely broken by #859.

Proposed Solution

  • Remove the "replace selection" checkbox
  • Allow for text selection to be replaced if a text selection is active in the code action toolbar (which currently only allows for the active cell to be replaced).
  • Implement a message-global "Replace selection" action within a hamburger menu at the top of each message (e.g. next to the timestamp). This should observe the same behavior as the Replace button in the code action toolbar, i.e. replace text if a text selection is active, replace cell if there exists an active cell, and render as disabled if neither condition is satisfied.
@dlqqq dlqqq added the enhancement New feature or request label Jun 30, 2024
@dlqqq dlqqq added this to the v2.19.0 milestone Jun 30, 2024
@dlqqq dlqqq added the priority label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority
Projects
None yet
Development

No branches or pull requests

1 participant