Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 19 #1869

Closed
Tracked by #27930
d-koppenhagen opened this issue Nov 19, 2024 · 14 comments · Fixed by #1871
Closed
Tracked by #27930

Support for Angular 19 #1869

d-koppenhagen opened this issue Nov 19, 2024 · 14 comments · Fixed by #1871
Assignees

Comments

@d-koppenhagen
Copy link

Is your feature request related to a problem? Please describe.
Since Angular 19 was released today, it should be supported by this package and therefore defined as allows peerDependency.

Describe the solution you'd like
bump version

Describe alternatives you've considered

Additional context

@salztorte
Copy link

+1

@just-jeb
Copy link
Owner

I wish it would be as simple as just bumping the version but unfortunately it's a process that requires a bit of work.
I'm really short on free time now but I'll do my best to do it ASAP.

@LanderBeeuwsaert
Copy link

We are getting failing tests with:
"No value provided for @angular/core symbol 'ɵɵStandaloneFeature'"
and
"ReferenceError: _ts_decorate is not defined"
any idea if this is because of that this library isn't adapted/upgraded to angular 19?

@salztorte
Copy link

@LanderBeeuwsaert I think the symbol ɵɵStandaloneFeature does not exist anymore in angular 19.
I searched for it in angular 18 and found something, but not in angular 19

@LanderBeeuwsaert
Copy link

@salztorte indeed would make sense now that standAlone has become the default.
But we upgraded all our angular packages to 19 so I suppose that it's the dependencies of this library that are still on 18 that are giving the issue:
image

@arturovt arturovt self-assigned this Nov 21, 2024
@arturovt arturovt linked a pull request Nov 22, 2024 that will close this issue
@bobbyquantum
Copy link

@arturovt #1871 passes CI if jest-preset-angular is updated to 14.4.0-rc.0, and all references to zone.js are updated to 0.15.0.

https://github.com/bobbyquantum/angular-builders/actions/runs/12028925443

@khvedela
Copy link

any updates on this issue ?

@bobbyquantum
Copy link

The final release of jest-preset-angular 14.4.0 is out now

@just-jeb
Copy link
Owner

just-jeb commented Dec 5, 2024

You're welcome to try out v19.0.0-beta.0 at @next tag.

@arturovt thanks for the amazing work!

@salztorte
Copy link

When is the release of v19 planed?
I do not want use a beta version in my project.

@just-jeb
Copy link
Owner

The beta version is beta not because we're actively working on something that should enter the release version, but in order to provide a grace period and catch things like this.
So if everything works for you don't wait.

In terms of timeline - if everything goes well I think we'll have a release within 2 weeks.

@salztorte
Copy link

salztorte commented Dec 20, 2024

@just-jeb Thank you.

I understand that updates take time and I don`t want to make pressure.
It is just that I also need to plan my projects.

@SchroederSteffen
Copy link

Tested it with some medium-sized projects and didn't encounter any issues. 👍

@SchroederSteffen
Copy link

I noticed only today that v19 has been released already: https://www.npmjs.com/package/@angular-builders/jest?activeTab=versions 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants