chore: don't select dead entities in combat

 - idk if this is quite the right solution. I think you want to set the entity enabled=False to avoid selection. 🤷

Author: justindujardin

src/app/routes/combat/behaviors/choose-action.machine.ts

@@ -79,9 +79,14 @@ export class ChooseActionType extends State<CombatChooseActionStateNames> {
     let sub: Subscription | null = null;
 
     let clickSelect = (click: CombatSceneClick) => {
+      const targetClick = click.hits[0];
+      // If the target has no HP, it's not a valid target.
+      if (!targetClick?.model?.hp) {
+        return;
+      }
       sub?.unsubscribe();
       sub = null;
-      machine.target = click.hits[0];
+      machine.target = targetClick;
       machine.parent.items[0].select();
     };
     assertTrue(machine.current, 'Requires Current Player');
@@ -221,6 +226,10 @@ export class ChooseActionTarget extends State<CombatChooseActionStateNames> {
         machine.setCurrentState(ChooseActionSubmit.NAME);
         return;
       }
+      // If the target has no HP, it's not a valid target.
+      if (!target?.model?.hp) {
+        return;
+      }
       machine.target = target;
       machine.parent.setPointerTarget(target, 'left');
     };

src/app/routes/combat/combat.component.ts

@@ -74,32 +74,21 @@ export class CombatComponent
   implements IProcessObject, OnDestroy, AfterViewInit
 {
   @Input() scene: Scene = new Scene();
-  /**
-   * A pointing UI element that can be attached to `SceneObject`s to attract attention
-   * @type {null}
-   */
+  /** A pointing UI element that can be attached to `SceneObject`s to attract attention */
   pointer: UIAttachment | null = null;
 
-  /**
-   * Available menu items for selection.
-   */
-  @Input()
-  items: ICombatMenuItem[] = [];
+  /** Available menu items for selection. */
+  @Input() items: ICombatMenuItem[] = [];
 
   /** The combat state machine */
   @ViewChild(CombatStateMachineComponent) machine: CombatStateMachineComponent;
 
-  /**
-   * Damages displaying on screen.
-   * @type {Array}
-   */
+  /** Damages displaying on screen. */
   @Input() damages: ICombatDamageSummary[] = [];
 
   @Input() defaultState: CombatStateNames | null = 'start';
 
-  /**
-   * Mouse hook for capturing input with world and screen coordinates.
-   */
+  /** Mouse hook for capturing input with world and screen coordinates. */
   mouse: NamedMouseElement | null = null;
 
   @ViewChild('combatCanvas') canvasElementRef: ElementRef;
@@ -318,7 +307,7 @@ export class CombatComponent
   }
 
   /**
-   * Render all of the map feature components
+   * Render all of the map features and combatants.
    */
   renderFrame(elapsed: number) {
     this.clearRect();