Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behaviour in Battlefield 2042 #113

Open
Shaydera opened this issue Nov 16, 2021 · 5 comments · May be fixed by #140
Open

Inconsistent behaviour in Battlefield 2042 #113

Shaydera opened this issue Nov 16, 2021 · 5 comments · May be fixed by #140
Labels

Comments

@Shaydera
Copy link

I've experienced inconsistent behaviour when using this tool for Battlefield 2042.
The vibrance change will only trigger around ~30% of the times when tabbing into the Game.

I have already tried to debug this and noticed that the Windows Event Hook sometimes just won't get called on bringing the game into foreground, in this cases it will be called on tabbing OUT of the game tho.

I did test this on a secondary machine too, so its not specific to my primary windows install.
Due to the fact that i have little knowledge of the Windows API, i don't know what can be done about this.
Also i need to add, that the Game is protected by "EasyAntiCheat", which may have something to do with this?

Greetings

@juv
Copy link
Owner

juv commented Nov 19, 2021

which version are you using?

@Shaydera
Copy link
Author

VibranceGUI Version 2.3.1.1 on a NVIDIA 3080Ti with Driver Version 496.76
Windows 10 21H1 (Build 19043.1348, up2date)

I've debugged with the current master branch.

@juv
Copy link
Owner

juv commented Nov 20, 2021

Thanks for trying to debug it. We also had a few occurences when people had similar issues;
I tried to add one more Windows event type to be informed by the hook. See here:

#95 (comment)
#95 (comment)

Maybe EVENT_SYSTEM_SWITCHEND could also be of interest. It's not clear what exactly the overlaps of these events are, it's mostly trial and error :/

 
The user has released ALT+TAB. This event is sent by the system, never by servers. The hwnd parameter of the WinEventProc callback function identifies the window to which the user has switched.If only one application is running when the user presses ALT+TAB, the system sends this event without a corresponding EVENT_SYSTEM_SWITCHSTART event.
 

@juv juv added the bug label Dec 7, 2024
@juv
Copy link
Owner

juv commented Dec 20, 2024

Hi @Shaydera,

can you please take a look at this new beta version i have built based on this PR: #140
Is the issue still reproducible? I have adjusted the way how to the application switch events are handled.

You can download the pre-release .exe here:
https://github.com/juv/vibranceGUI/releases/tag/v2.5.0

@juv juv linked a pull request Dec 20, 2024 that will close this issue
@Shaydera
Copy link
Author

Hi @juv,

Thank you for your response and the effort you’ve put into addressing this issue.
I’m afraid I won’t be able to test the new beta version in the near future. I’m currently quite busy with other priorities, and I no longer play Battlefield 2042 and mostly stopped using VibranceGUI in favor of FreeStyle filters, where available and the few cases I still use it with (Escape from Tarkov e.g.) do not experience this Issue.

Thanks again for your work, and best of luck with the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants