Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vibrance on laptops is possible #19

Closed
JoiNNN opened this issue Mar 27, 2016 · 41 comments
Closed

Vibrance on laptops is possible #19

JoiNNN opened this issue Mar 27, 2016 · 41 comments

Comments

@JoiNNN
Copy link

JoiNNN commented Mar 27, 2016

I wanted to try the app and noticed that there is no laptop support the reason being that nVIDIA didn't include support for vibrance. However this is not entirely true. On modern laptops at least, you have control for Vibrance via the Intel's Graphics Control Panel, is named Saturation.
gfxv4_0_2016-03-27_22-04-03
This is because the integrated GPU is the one handling the image output to the display and not the nVIDIA GPU. The dedicated GPU is like an addon in this case, that does the heavy lifting when necessary then passes information to the integrated GPU which then outputs it to the screen.
What I'm trying to say is that there is the possibility of adding support for laptops given you have the resources to do so in terms of Intel API documentation on this matter, in which I haven't looked at all so I wont be able to provide more information.

Anyway thanks for the app, will definitely use it on my desktop PC.

@juv
Copy link
Owner

juv commented Mar 27, 2016

Hi,

as there were many requests to adding Intel support to vibranceGUI, I've researched whether there is an API that allows to retrieve and change the color settings of a specific display. Apparently there is no public API at all. Furthermore I do not have access to a laptop where I could test the Intel support. Trying to get it running without access to a laptop that is able to run the program is like finding a needle in a haystack. If there was such an API, someone else would have to program the Intel support, like @juriii did for AMD graphic cards.

@aPollO2k
Copy link

aPollO2k commented Jun 9, 2016

Also if external display is in use and the HDMI/DisplayPort is directly connected to the nvidia gpu there IS a option for digital vibrance in the nvidia driver. vibranceGUI works well with external display BUT if i add it to the system startup i get every time an error while no external display is connected. Maybe you can make a little feature.
I think its very useful if vibranceGUI can check if there is an external display/digital vibrance option and then start or just idle if there is not.

Sorry my english is not very well. I hope everyone understands.

@luisrudge
Copy link

I don't have these options in my control panel :(

image

image

http://www.lg.com/us/monitors/lg-29UM67-P-ultrawide-led-monitor

Any thoughts?

@daniele-salvagni
Copy link

It is indeed possible, the problem as @juvlarN said is that there isn't a public API. I managed to reverse engineer the Intel HD Graphics Control Panel, it is using a proprietary library called igfxDHLib.dll which is obviously not documented. I managed to reverse that too (I'm still not sure about some parts of the library) and to put together some code about 5 months ago that has been working perfectly for me ever since.

It wasn't intended for public release (bad code warning) and I didn't had the time to keep working on it. I also suspect that it won't immediately work for any system as some stuff might vary based on the GPU/Driver version. If you want to try it out this is the repository: https://github.com/daniele-salvagni/color-goggles

My laptop is a dual-graphichs Sony Vaio S13P with an Intel® Core™ i7-3520M (HD Graphics 4000), it may not work for different systems (I didn't had any other system to compare/test).

Anyways on some version of the Intel Control Panel it is possible to setup profiles to switch profiles automatically when you open certain applications, is is a bit wonky but it might be worth looking into.

@zerox06
Copy link

zerox06 commented Jul 26, 2017

Hello Daniele, I interested to try your stuff, im new on github, I thought that I could find a .exe to start the software but there isn't :/

I got a 960m and i7 6700hq

Thank you for answer

@daniele-salvagni
Copy link

daniele-salvagni commented Jul 26, 2017

Hi @zerox06, you can find a download link for the executable here: http://dan.salvagni.io/s/color-goggles/, there is a Test button in the application which should increase your saturation to minimum, maximum and back to normal if it is working. It may just crash as I was able to test this only on my system, it is just a fast "prototype" so I didn't take the time to manage exceptions. Let me know how it goes via email (you can find it in my GitHub profile) so we don't pollute too much this discussion which should be used just for VibranceGUI.

Edit November 2017: Got a new laptop, so I was able to fix a problem which made the application crash on some newer systems.

@Dreamer707
Copy link

Hello JoiNNN I have a intel i5 and I dont have these settings... why?

@avaque
Copy link

avaque commented Jan 7, 2018

@daniele-salvagni the thing is that your program simply alters what we can already do ourselves in intel control panel (as displayed in the pic on top of the post)
im looking to go further if its possible, cause vibrancegui pushes it so much further, but then again it may not be possible simply cause of intels dumbass limits

@daniele-salvagni
Copy link

daniele-salvagni commented Jan 7, 2018

@avaque VibranceGUI does the same but with Nvidia Settings, staying within the limits dictated by Nvidia. It is not possible to further increase the vibrance via software while still being VAC safe, I might check if the Intel limit can be bypassed on the driver level but I won't get my hopes up about that.

Edit: it looks like the driver limit can be bypassed in some cases, give me a sec.

@daniele-salvagni
Copy link

daniele-salvagni commented Jan 7, 2018

It is kinda possible to bypass the limit, however we fall in the undefined behaviour realm (this should also be device-dependent). This is what happens at different saturation levels:

  • 0%: Normal level
  • 100%: Intel limit
  • 330%: Sweet spot beyond the limit

From here the saturation starts to affect the hue effectively decreasing the visibility:

  • 470%: Green hue takes over
  • 950%: Red hue takes over

sat

I will investigate this further and push a new version to take advantage of this, however it might take a while as I will be quite busy for the next month or so.
You will find the update here when available: https://github.com/daniele-salvagni/color-goggles/releases

@zerox06
Copy link

zerox06 commented Jan 7, 2018 via email

@avaque
Copy link

avaque commented Jan 8, 2018

@daniele-salvagni the 330% is just what im looking for. Ive searched alot and found nothing which could lead to further saturation increase than what i have right now. Only closest thing ive found is Color filter option in Windows 10 where the "Deuteranopia" option increases saturation but only of green and red colors.

@daniele-salvagni
Copy link

Color-Goggles v1.0.0 is out: http://dan.salvagni.io/s/color-goggles/

CG

It is a complete rewrite of the applciation and it is now possible to increase the saturation up to 320% (check the Remove limits option). I just sold my old laptop, so I wasn't able to test it on more than one device, please let me know how it goes. You can contact me directly at @sdlnv on twitter or [email protected].

@avaque
Copy link

avaque commented Jan 9, 2018

@daniele-salvagni thank you sooo much. I just dont understand why didnt intel do it in the first place.

@NeedHelperino
Copy link

@daniele-salvagni i need to find a file name igfxDHLib.dll but i dont have that file in my filerepository

@avaque
Copy link

avaque commented Jan 14, 2018

@NeedHelperino its in one of the folders definitelly, have you tried searching "igfxdhlib"in the search tab?
and pick the newest one by date

@daniele-salvagni
Copy link

daniele-salvagni commented Jan 14, 2018

@NeedHelperino I need some more details in order to be able to help you. Are you on a Desktop/Laptop? What's your CPU? Do you have a dedicated GPU? Which one? Do you have access to the Intel Control Panel?

@NeedHelperino
Copy link

Yes i have an Laptop i have an I3-3217U CPU and an dual GPU 1st GPU intel hd graphics and my 2nd GPU is an 770M Nivida

@NeedHelperino
Copy link

@avaque yes i did find it but i dont know where to put the file

@avaque
Copy link

avaque commented Jan 14, 2018

@NeedHelperino in the same folder with the colorgoggles.exe and its .dll

@NeedHelperino
Copy link

@avaque look this might seem pretty stupid but when i extract the file i dont know where to put it i cant find it in my roaming i cant find it in my download page i dont know where to look

@daniele-salvagni
Copy link

You can extract color-goggles.exe wherever you want, even in a folder on the Desktop. You then need to copy IgfxDHLib.dll you found in the same folder as color-goggles.exe.

@NeedHelperino
Copy link

i made a new map put it on my desktop than got the extracted files put them in the map and copied the IgfxDHLib.dll in to the map what now

@avaque
Copy link

avaque commented Jan 14, 2018

if by "map" you mean "folder" then just launch the .exe

@freaky1337
Copy link

freaky1337 commented Apr 28, 2018

@daniele-salvagni Is your program VAC safe?

@avaque
Copy link

avaque commented Apr 28, 2018

@freaky1337 Unlike SweetFX this program doesnt change 3d vibrance but rather overall vibrance. Its just like applying a filter over your screen. Its completely VAC safe. Nvidia Freestyle has this same option but it will probably get disabled for CSGO soon and it lowers your FPS anyways, while Colorgoggles doesnt.

@freaky1337
Copy link

freaky1337 commented Apr 28, 2018

The program doesn't do anything, and my anti-virus detects it.

@avaque
Copy link

avaque commented Apr 28, 2018

@freaky1337 so does everyone's antivirus. Have you followed the instructions to install it?

@freaky1337
Copy link

freaky1337 commented Apr 28, 2018

I have

@freaky1337
Copy link

My AV didn't detect VibranceGUI

@avaque
Copy link

avaque commented Apr 28, 2018

@Freak1337 then use vibranceGUI man idk what to tell you if you worried about getting a virus from this just dont use it.

@freaky1337
Copy link

can't,cuz i have laptop

@daniele-salvagni
Copy link

@freaky1337 Which antivirus are you using? I can't get a positive result on any of them.
Anyway you should be able to add the file as an exception in your AV settings.

@brandons101
Copy link

I'm on my desktop and I don't have a igfxDHLib.dll what should I do?

@Dreamer707
Copy link

Dreamer707 commented Dec 24, 2018 via email

@daniele-salvagni
Copy link

Sorry for the delay @brandons101, if you are using the new DCH drivers, you should try following these instructions: daniele-salvagni/color-goggles#16 (comment)

@ars-ratnik
Copy link

While looking online I found several articles saying that digital vibrance and saturation are different things. It said that digital vibrance will not saturate darker colors and will only saturate lighter colors, while the saturation option will saturate all colors making dark colors extremely dark. If this is true is there any way to get around the saturation bumping up dark colors.

@jurij jurij closed this as completed Apr 14, 2020
@njanadesign
Copy link

when I use Color-Goggles, my FPS drops on csgo :(

@daniele-salvagni
Copy link

when I use Color-Goggles, my FPS drops on csgo :(

This is not possible, you can even close Color-Goggles after changing the saturation because it will not be doing anything at all. If your FPS are dropping there is another reason.

@Kretisy
Copy link

Kretisy commented Dec 14, 2020

Im on a desktop with intel UHD 630 graphics and i cant find igfxDHLib.dll what should i do?

@Younase
Copy link

Younase commented Jan 17, 2022

vibranceGUI didn't work for me (since nvidia laptops are not supported) so i made this script, hope it helps someone.
https://gist.github.com/Younase/5cc1114812e7839585c06964086e3c1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests