Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the LSP implementation at Eclipse.org, with Ceylon #9

Open
mickaelistria opened this issue Jun 15, 2017 · 17 comments
Open

Put the LSP implementation at Eclipse.org, with Ceylon #9

mickaelistria opened this issue Jun 15, 2017 · 17 comments
Labels

Comments

@mickaelistria
Copy link

The Ceylon language is in the process of moving to the Eclipse.org Foundation to ensure good governance: https://projects.eclipse.org/proposals/eclipse-ceylon . The Eclipse Foundation is also the host of the LSP4J project that is used by the implementation of Ceylon Language Server, and of several LSP related initiatives ( https://www.eclipse.org/community/eclipse_newsletter/2017/may/ ). It would make a lot of sense to move the Ceylon LSP implementation inside the Ceylon project as soon as this is moved to Eclipse.org !

@jvasileff
Copy link
Owner

It would be fine with me for the Eclipse/Ceylon project to absorb this project, but I think the decision would be up to @gavinking and @FroMage.

So far, I am the only contributor. I suspect we'd want to see more activity and interest before making this officially supported by the Ceylon project.

@FroMage
Copy link

FroMage commented Jun 16, 2017

I'm not opposed to it at all, but I think we should first wait for Eclipse to accept or not Ceylon.

@ShalokShalom
Copy link

ShalokShalom commented Mar 28, 2018

How to succeed?

@mickaelistria
Copy link
Author

mickaelistria commented Mar 29, 2018

The Eclipse Ceylon project is now provisionned and working. So I think the migration of the LS to github.com/eclipse/ceylon would now be possible. Even the VSCode specific parts could actually be part of the Ceylon project at Eclipse.org (but it would still be better to split those 2 parts in 2 distinct contributions).
@jvasileff Are you interested? If you are and @FroMage approves the idea, I'd be glad to provide some organisational assistance in completing this migration, which would ultimately lead to faster integration of Ceylon features in the LS, more visibility of the LS for the Ceylon lang community and simplified inclusion in other IDE such as Eclipse IDE, Eclipse Che, and so on.

@davidfestal
Copy link
Collaborator

@mickaelistria @FroMage After speaking with @jvasileff, I've already started looking into integrating his previous work on the VSCode LSP, with the ceylon-ide-common project. My goal is to produce a Ceylon LSP implementation that would inherit the numerous features already available in ceylon-ide-common (refactorings, completion, Java interop, etc ...).

However, it is in an early stage, and I didn't push anything for now, but I would expect adding it into the eclipse Ceylon GitHub repositories at some stage, under the repo: ceylon-language-server and with sources in the following base package: org.eclipse.ceylon.ide.lsp.

Since there's no planned date for the Eclipse Ceylon 1.4 release for now, I started this work based on the 1.3.3 Ceylon release, so that it can become available as soon as possible without waiting for Ceylon 1.4. Is it a problem (since 1.3.3 was released before Ceylon joining Eclipse) ?

@mickaelistria
Copy link
Author

Thanks @davidfestal

@davidfestal
Copy link
Collaborator

Since there's no planned date for the Eclipse Ceylon 1.4 release for now, I started this work based on the 1.3.3 Ceylon release, so that it can become available as soon as possible without waiting for Ceylon 1.4. Is it a problem (since 1.3.3 was released before Ceylon joining Eclipse) ?

@mickaelistria wdyt about this question ?

@mickaelistria
Copy link
Author

As a user or an integrator, I'm fine with it.

About the legal part, I guess that Ceylon 1.3.3 was already IP-approved by Eclipse Fondation, wasn't it?
If so, it means that you could check in your code depending on 1.3.3 at Eclipse.org without issue, as long as you do not modify the code of your dependencies.
If not, then it could be interesting to consider having the Ceylon project requesting IP approval for earlier releases of Ceylon to allow such "downstream" effort to join the club at Eclipse.org.

Another possibility, if there is no deadline nor constraints, would be that you write the LS on top of Ceylon 1.4 snapshot, and just release this together with Ceylon 1.4. But doing this, it means you couldn't release the LS earlier. Not sure whether it would be an issue.
It wouldn't be for me as my interest in Ceylon is only curiosity and "like", it's not something I or my team have goals built on top of.

@minkir014

This comment has been minimized.

@ShalokShalom

This comment has been minimized.

@minkir014

This comment has been minimized.

@minkir014

This comment has been minimized.

@ShalokShalom

This comment has been minimized.

@jvasileff

This comment has been minimized.

@minkir014

This comment has been minimized.

@jvasileff
Copy link
Owner

I've hidden the questions/comments about debugging. Please keep comments germane to the issue. Thanks!

@minkir014

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants