Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial relative moveto incorrectly merged #111

Closed
jzbrooks opened this issue Nov 28, 2024 · 0 comments · Fixed by #113
Closed

Initial relative moveto incorrectly merged #111

jzbrooks opened this issue Nov 28, 2024 · 0 comments · Fixed by #113
Labels
bug Something isn't working

Comments

@jzbrooks
Copy link
Owner

jzbrooks commented Nov 28, 2024

The particular problem in #101 was incidentally addressed in #109 because the paths happen to overlap, but there are two cases that probably deserve consideration when merging paths that don't overlap.

  1. If the initial moveto is relative and it has no implicit parameters, it should be made absolute before merging. Initial movetos are always relative to the origin (e.g. absolute), but if it is merged into a new path, then semantically it would be relative to the current point in the path, which wouldn't be correct.
  2. If the initial moveto is relative and it has implicit lineto parameters (coordinate pairs after the first), then the command and all coordinates will need to be absolutized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant