Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace R8 binary with maven dependency #49

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jul 19, 2024

OLD: vgo.before
NEW: vgo.after

 JAR   │ old │ new │ diff
───────┼─────┼─────┼──────
 class │ 0 B │ 0 B │  0 B
 other │ 0 B │ 0 B │  0 B
───────┼─────┼─────┼──────
 total │ 0 B │ 0 B │  0 B

 CLASSES │ old │ new │ diff
─────────┼─────┼─────┼───────────
 classes │   0 │   0 │ 0 (+0 -0)
 methods │   0 │   0 │ 0 (+0 -0)
  fields │   0 │   0 │ 0 (+0 -0)

Comment on lines 13 to 17
content {
includeGroupByRegex("com\\.android.*")
includeGroupByRegex("com\\.google.*")
includeGroupByRegex("androidx.*")
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a problem/conflict including the entire google maven repo (removing the constraints)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Add these regex will speed up downloading.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By how much? I lean toward the simpler change, but I could be convinced if it was a big perf swing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No much effects for small projects. I can revert this if you want.

@jzbrooks
Copy link
Owner

Thanks!

@jzbrooks jzbrooks merged commit 951a3fb into jzbrooks:master Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants