Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the possibility to switch language for pokemon names #86

Open
gdemonteynard opened this issue Dec 14, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@gdemonteynard
Copy link

gdemonteynard commented Dec 14, 2023

Current behaviour (optional)

Currently, the names of the pokemon displayed in the tooltip when hovering are exclusively in english.

Description of the desired feature (required)

I would like to add the possibility to switch language in the settings so that the names could be displayed in the desired one.

Why this feature would be valuable (optional)

I am french, so I don't know many of the english names of the pokemons. Therefore, it is often hard for me to understand which pokemon is displayed when I don't recognise it's picture.

How to implement this feature (optional)

Adding a new option in the settings to switch to the desired language. My suggestion would be to use specific bundles (properties files) inventoring names of every pokemons in the desired language.

@gdemonteynard gdemonteynard added the enhancement New feature or request label Dec 14, 2023
@kagof
Copy link
Owner

kagof commented Feb 18, 2024

Hi @gdemonteynard, this is a really great idea that I'd love to implement. Agreed that using resource bundles will be the proper way to do this. I'll try to handle this at some point in the near future, and get it localized with at least English as a default and hopefully French as well. Once that's done, hopefully it'll make it easy for other contributors to add their own languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants