Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon not working under e10s, Options page hangs #32

Open
theultramage opened this issue Sep 11, 2018 · 2 comments
Open

Addon not working under e10s, Options page hangs #32

theultramage opened this issue Sep 11, 2018 · 2 comments

Comments

@theultramage
Copy link

theultramage commented Sep 11, 2018

I updated from ESR 52 to 56.0.2. This updated the addon from 1.5 to 2.0. The list of hashes was converted, but the configured sites are not being blocked from history. The addon seems to not be working. However, the Historyblock dynamic context menu does get added, so it actually is?

When I open the addon's Options page, clicking on any toggle or button makes the page freeze, and the change is not recorded. Manually resetting the blocklist and restarting does not solve the issue.

The browser console reports the following when I click on anything:

window.gBrowser is undefined  RemotePrompt.jsm:41
call trace:
	openTabPrompt resource:///modules/RemotePrompt.jsm:41:9
	receiveMessage resource:///modules/RemotePrompt.jsm:33:11
	receiveMessage jar:file:///C:/Program%20Files/Mozilla%20Firefox/browser/omni.ja!/components/nsBrowserGlue.js:205:15
	receiveMessage self-hosted:991:17

EDIT: Disabling e10s restores all functionality, but it makes the browser stutter a lot when loading new tabs. Would it be possible to make HistoryBlock e10s-compatible?
EDIT2: I guess this is essentially a wordier duplicate of #25...

@theultramage theultramage changed the title Addon not working, Options page hangs Addon not working under e10s, Options page hangs Sep 11, 2018
@Tampa
Copy link

Tampa commented Sep 16, 2021

Would be nice to get this fixed up, maybe instead of a user prompt to manage the list instead just adding a button to the addon bar for "add this host to blacklist"?

@theultramage
Copy link
Author

The bugzilla page in the linked issue mentions it being 'verified as fixed' in FF58. I did not have the opportunity to verify if the extension works in latest FF. I also no longer remember the reason why I was testing it on FF56, when at the time of writing, FF62 was already available. Possibly because of compatibility issues with some other old extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants