File tree Expand file tree Collapse file tree 1 file changed +2
-9
lines changed Expand file tree Collapse file tree 1 file changed +2
-9
lines changed Original file line number Diff line number Diff line change @@ -457,19 +457,12 @@ func fetchRemoteConfig(url string) (*Config, error) {
457457 )
458458
459459 if err != nil {
460- // TODO: improve logging
461- fmt .Printf ("WARNING: Couldn't fetch config_url: %s" , err )
460+ // TODO: This keeps the old behaviour but IMHO we should return an error here
462461 return result , nil
463462 }
464463
465464 if ! HasValidHeader (string (body )) {
466- // TODO: Print a warning when we implement proper logging
467- if err != nil {
468- fmt .Printf ("No valid header in remote config: %s\n " , err .Error ())
469- } else {
470- fmt .Println ("No valid header in remote config" )
471- }
472-
465+ // TODO: This keeps the old behaviour but IMHO we should return an error here
473466 return result , nil
474467 }
475468
You can’t perform that action at this time.
0 commit comments