Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support private repository when using kairos-agent bundle-install #3057

Closed
Bao0ne opened this issue Dec 6, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call

Comments

@Bao0ne
Copy link

Bao0ne commented Dec 6, 2024

Is your feature request related to a problem? Please describe.

When I tried to use bundle to publish software, I found that it had no way to pull images from the private repository.

Describe the solution you'd like

Hope it will be supported when kairos-agent install-bundle:

  • Provide private repository authentication
  • Read repository information from the specified configuration file like luet install --config

Additional context

Currently, authentication information cannot be added when luet repo add, I try to make it support:mudler/luet#370

In kairos-sdk:https://github.com/kairos-io/kairos-sdk/blob/d334d86d4369929e47d569d9d8a6eeb4698e55ca/bundles/bundles.go#L287

Is it expected to point the software installation location(--system-target) and repo config to the same location? I think most of the time software needs a separate directory for storage.

In kairos-sdk:https://github.com/kairos-io/kairos-sdk/blob/d334d86d4369929e47d569d9d8a6eeb4698e55ca/bundles/bundles.go#L304

@Bao0ne Bao0ne added enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call labels Dec 6, 2024
@jimmykarily jimmykarily moved this to In Progress 🏃 in 🧙Issue tracking board Dec 9, 2024
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Dec 9, 2024
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Dec 16, 2024
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Dec 16, 2024
@jimmykarily jimmykarily moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board Dec 16, 2024
@jimmykarily jimmykarily assigned jimmykarily and Bao0ne and unassigned jimmykarily Dec 16, 2024
@mudler
Copy link
Member

mudler commented Dec 23, 2024

PR was merged, thanks @Bao0ne !

mudler/luet#370

Closing this Issue

@mudler mudler closed this as completed Dec 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🏃 to Done ✅ in 🧙Issue tracking board Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call
Projects
Archived in project
Development

No branches or pull requests

3 participants