Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIFAnimatable animate method completion handler doesn't work as expected #140

Open
wehttam0 opened this issue Feb 18, 2019 · 3 comments
Open
Labels

Comments

@wehttam0
Copy link

How is the completion handler parameter below intended to work?

public func animate(withGIFNamed imageName: String, loopCount: Int = 0, completionHandler: (() -> Void)? = nil)

Per the api docs it says:
completionHandler | Completion callback function

The issue is that the completion handler is fired immediately and not when the animations are finished. Seems that the completionHandler is being used by prepareForAnimation and therefore firing immediately. Is this by design?

Link to the API

@kaishin kaishin added the bug label Nov 30, 2019
@RichardFevrier
Copy link
Contributor

The doc is not up-to-date 🙂

@kaishin
Copy link
Owner

kaishin commented Jan 29, 2020

I will fix. Thanks for pointing this out!

@RichardFevrier
Copy link
Contributor

You're welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants