Experimental indentation doesn't work for multiline strings

[30350n]

Formatter input:

[
  ''
     foo
    bar
  ''
]

Expected output (with indentation = "FourSpaces"):

[
    ''
         foo
        bar
    ''
]

Actual output (with indentation = "FourSpaces"):

[
    ''
       foo
      bar
    ''
]

Expected output (with indentation = "Tabs", -> symbolize tabs):

[
->''
->-> foo
->->bar
->''
]

Actual output (with indentation = "Tabs"):

[
->''
->   foo
->  bar
->''
]

[30350n]

My guess is that this is being caused by this:

alejandra/src/alejandra/src/rules/string.rs

Lines 96 to 100 in 7da44e0

	if !line.trim().is_empty() {
	format!(" {}", line)
	} else {
	line.to_string()
	}

I've tried to rewrite it like this:

if !line.trim().is_empty() { 
    format!(
        "{}{}",
        match build_ctx.config.indentation {
            Indentation::FourSpaces => "    ",
            Indentation::Tabs => "\t",
            Indentation::TwoSpaces => "  ",
        },
        line
    ) 
} else { 
    line.to_string() 
}

But while this seems to work for "FourSpaces", from my testing, it doesn't do the trick for "Tabs".

[exscientiafortis]

I think you are right and unless I am missing something that change seems to work fine for me, for both FourSpaces and Indentation.

Could it be you were bitten by editor settings formatting your out.nix (happened to me initially)?

I went ahead and opened #448 with you as author. Let me know if that's not ok, happy to close it.

[30350n]

Could it be you were bitten by editor settings formatting your out.nix (happened to me initially)?

I don't think so. I copied the string test folder to indentation-tabs and reformated the out.nix using my editor to test things. (So I manually formated the out.nix to be what I'd consider to be correct.)

[kamadorueda]

@exscientiafortis @30350n I think you guys fixed this right? If so, let's close this issue

[exscientiafortis]

I think Bobbe's change was strictly positive, but I do confirm the full string test cases do fail in a number of places for tab indentation, so there must be other issues. I might have some time this month to look at it.