Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new relic reporter should use a licence key as a new way to authenticate #1248

Open
bwiercinski opened this issue Jan 12, 2023 · 0 comments
Open

new relic reporter should use a licence key as a new way to authenticate #1248

bwiercinski opened this issue Jan 12, 2023 · 0 comments

Comments

@bwiercinski
Copy link
Contributor

the NR documentation (chapter about keys) states that Insights insert key are deprecated / not recommended.

This key is still in use but we highly recommend using the license key, which can be used for the same things and more.

when using SpanBatchSender.configurationBuilder or MetricBatchSender.configurationBuilder a special useLicenseKey parameter can be passed that indicates that the passed api key is either insights insert key or licence key.

technically this will result passing either "Api-Key" or "X-License-Key" respectively header in the request.

i will make MR for that
@bwiercinski bwiercinski mentioned this issue Jan 12, 2023
Merged
ivantopo pushed a commit that referenced this issue Jan 23, 2023
@bwiercinski @matwojcik
#1248 add a support for New Relic's licence key (#1249)
5bade8d 
* add a support for New Relic's licence key
- changes are compatible backwards
- extracted config parsing to the new file
- new `"licence-key"` can be passed
- added new tests

* remove apiKeyAndUseLicenseKey, because of tuple

* add license-key to the reference.conf

* Update reporters/kamon-newrelic/src/main/scala/kamon/newrelic/spans/SpanBatchSenderBuilder.scala

Co-authored-by: Mateusz Wójcik <[email protected]>

Co-authored-by: Mateusz Wójcik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwiercinski